22 messages in net.java.openjdk.bsd-port-devRe: Patch to build 64 bit VM| From | Sent On | Attachments |
|---|---|---|
| Xiaobin Lu | Dec 17, 2008 9:13 pm | |
| Xiaobin Lu | Dec 17, 2008 9:22 pm | |
| Greg Lewis | Dec 22, 2008 6:09 am | |
| Xiaobin Lu | Dec 22, 2008 11:05 am |  .Other |
| Landon Fuller | Dec 22, 2008 11:25 am | |
| Greg Lewis | Dec 25, 2008 11:23 pm | |
| Xiaobin Lu | Dec 25, 2008 11:34 pm | |
| Greg Lewis | Dec 26, 2008 9:26 am | |
| Greg Lewis | Dec 28, 2008 12:28 am | |
| Greg Lewis | Dec 28, 2008 12:54 pm | .diff |
| Xiaobin Lu | Dec 28, 2008 1:35 pm | |
| Greg Lewis | Dec 29, 2008 8:45 am | |
| Xiaobin Lu | Dec 31, 2008 8:32 pm | |
| Michael Franz | Jan 2, 2009 7:58 pm | |
| Kelly O'Hair | Jan 3, 2009 10:59 am | |
| Greg Lewis | Jan 4, 2009 9:18 pm | |
| Michael Franz | Jan 5, 2009 4:42 am | |
| Xiaobin Lu | Jan 5, 2009 11:14 am | |
| Michael Franz | Jan 5, 2009 4:43 pm | |
| Greg Lewis | Jan 5, 2009 10:11 pm | |
| Dalibor Topic | Jan 6, 2009 4:45 am | |
| Michael Franz | Jan 6, 2009 7:36 am |
| Subject: | Re: Patch to build 64 bit VM | |
|---|---|---|
| From: | Greg Lewis (gle...@eyesbeyond.com) | |
| Date: | Dec 25, 2008 11:23:27 pm | |
| List: | net.java.openjdk.bsd-port-dev | |
G'day Xiaobin,
On Mon, Dec 22, 2008 at 11:06:30AM -0800, Xiaobin Lu wrote:
I am attaching the patch to make the VM build pass on Mac OS 64 bit. Here is some explanation on the change:
bytes_bsd_x86.inline.cpp:
Change bswap16(x) to bswap_16(x) and the similar, I believe there was a typo for this. When some ported this to Apple platform, they missed a underscore.
os_bsd_x86.cpp
There was a "}" missing for 64 bit build.
Thats a lot clearer when I use diff -b :).
Other changes to make the build pass will be covered by my fix to 6787106 which I am going to put back to open JDK 7 tree soon.
Please help me review the patch and feel free to let me know if there was anything wrong.
Looks good to me -- I say go ahead and commit it.
Greg Lewis wrote:
G'day Xiaobin,
On Wed, Dec 17, 2008 at 09:14:16PM -0800, Xiaobin Lu wrote:
I am attaching the patch for building 64 bit VM. They are BSD specific files. Would someone review it and help me check it in?
Sure. Can you comment a little on the changes to src/os_cpu/bsd_x86/vm/bytes_bsd_x86.inline.hpp? It seems like the diff is bigger than the changes if that makes sense (i.e. there are some whitespace changes due to control flow changes which are hiding those).
-- Greg Lewis Email : gle...@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : gle...@FreeBSD.org