atom feed69 messages in com.selenic.mercurial-develRe: [PATCH 2 of 4] commit: warn when ...
FromSent OnAttachments
Martin GeislerMay 7, 2010 10:33 am 
Dirkjan OchtmanMay 7, 2010 10:37 am 
Matt MackallMay 7, 2010 10:59 am 
Martin GeislerMay 7, 2010 11:14 am 
Matt MackallMay 7, 2010 11:46 am 
Dirkjan OchtmanMay 7, 2010 1:14 pm 
Gilles MorisMay 8, 2010 12:10 am 
Martin GeislerMay 8, 2010 1:31 am 
Martin GeislerMay 8, 2010 1:34 am 
Martin GeislerMay 8, 2010 1:48 am 
Martin GeislerMay 8, 2010 2:09 am 
Gilles MorisMay 8, 2010 3:50 am 
Martin GeislerMay 8, 2010 1:10 pm 
Gilles MorisMay 9, 2010 9:33 am 
Gilles MorisMay 9, 2010 1:49 pm 
Gilles MorisMay 9, 2010 1:49 pm 
Gilles MorisMay 9, 2010 1:49 pm 
Gilles MorisMay 9, 2010 1:49 pm 
Gilles MorisMay 9, 2010 1:49 pm 
Matt MackallMay 9, 2010 2:36 pm 
Matt MackallMay 9, 2010 2:43 pm 
Matt MackallMay 9, 2010 2:45 pm 
Matt MackallMay 9, 2010 2:47 pm 
Martin GeislerMay 9, 2010 4:11 pm 
Dirkjan OchtmanMay 9, 2010 10:50 pm 
Gilles MorisMay 9, 2010 11:31 pm 
Gilles MorisMay 9, 2010 11:49 pm 
Matt MackallMay 10, 2010 12:04 am 
Gilles MorisMay 10, 2010 12:37 am 
Gilles MorisMay 10, 2010 12:37 am 
Matt MackallMay 10, 2010 12:38 am 
Matt MackallMay 10, 2010 12:58 am 
Sune FoldagerMay 11, 2010 2:02 am 
Sune FoldagerMay 11, 2010 2:08 am 
Sune FoldagerMay 11, 2010 2:14 am 
Sune FoldagerMay 11, 2010 2:20 am 
Matt MackallMay 11, 2010 3:53 pm 
Matt MackallMay 11, 2010 3:56 pm 
Gilles MorisMay 12, 2010 12:52 am 
Gilles MorisMay 12, 2010 1:15 am 
Gilles MorisMay 12, 2010 1:15 am 
Gilles MorisMay 12, 2010 1:15 am 
Gilles MorisMay 12, 2010 1:15 am 
Gilles MorisMay 12, 2010 1:15 am 
Gilles MorisMay 12, 2010 5:17 am 
Augie FacklerMay 12, 2010 7:35 am 
Matt MackallMay 12, 2010 8:33 am 
Matt MackallMay 12, 2010 8:34 am 
Matt MackallMay 12, 2010 8:34 am 
Matt MackallMay 12, 2010 8:55 am 
Gilles MorisMay 12, 2010 2:33 pm 
Gilles MorisMay 13, 2010 7:31 am 
Matt MackallMay 13, 2010 1:48 pm 
Martin GeislerMay 17, 2010 1:09 am 
Martin GeislerMay 17, 2010 1:22 am 
Rafael Villar Burke (Pachi)May 17, 2010 2:07 am 
Augie FacklerMay 17, 2010 5:57 am 
Martin GeislerMay 17, 2010 6:56 am 
Augie FacklerMay 17, 2010 7:46 am 
Martin GeislerMay 17, 2010 8:13 am 
Augie FacklerMay 17, 2010 8:41 am 
Gilles MorisMay 19, 2010 8:00 am 
Martin GeislerMay 19, 2010 3:53 pm 
Martin GeislerMay 19, 2010 3:58 pm 
Augie FacklerMay 24, 2010 5:15 am 
Peter ArrenbrechtMay 26, 2010 6:23 am 
Rafael Fernández LópezJun 3, 2010 5:35 am 
Peter ArrenbrechtJun 3, 2010 6:14 am 
Martin GeislerJun 4, 2010 12:18 am 
Subject:Re: [PATCH 2 of 4] commit: warn when resurrecting a closed changeset
From:Martin Geisler (mg@lazybytes.net)
Date:May 9, 2010 4:11:49 pm
List:com.selenic.mercurial-devel

Matt Mackall <mp@selenic.com> writes:

On Sun, 2010-05-09 at 22:50 +0200, Gilles Moris wrote:

# HG changeset patch # User Gilles Moris <gill@free.fr> # Date 1273437726 -7200 # Node ID 3615f282d6f08fb99976b86816ff37c019b8187a # Parent 9ab8b7dc5065557877d765b4f524ceb9cb1751e3 commit: warn when resurrecting a closed changeset

diff -r 9ab8b7dc5065 -r 3615f282d6f0 mercurial/commands.py --- a/mercurial/commands.py Sun May 09 22:37:18 2010 +0200 +++ b/mercurial/commands.py Sun May 09 22:42:06 2010 +0200 @@ -743,6 +743,11 @@ (parents[1] == nullrev or len(cl.heads(cl.node(parents[1]))) > 1)): ui.status(_('created new head\n'))

+ if not opts.get('close_branch'): + for r in parents: + if repo[r].extra().get('close'): + ui.status(_('resurrecting closed changeset %d\n') % r) +

We might want -f here. s/resurrecting/reopening/ and s/changeset/branch head/?

Yeah, I agree with you on all three points. The current concept is open/closed branch heads, so we shouldn't talk about resurrecting.

Also, it's not the closed changeset that is reopened (the changeset remains "closed" since it does not change) it is the branch head that is reopened by virtue of being moved forward to a non-closed (open) changeset.

Fast and powerful revision control: http://mercurial.selenic.com/