12 messages in com.xensource.lists.xen-develRe: [Xen-devel] The two image formats...
FromSent OnAttachments
Kevin Wolf25 Mar 2008 10:25 
Otavio Salvador25 Mar 2008 11:58 
Keir Fraser26 Mar 2008 01:10 
Kevin Wolf26 Mar 2008 01:49 
Otavio Salvador26 Mar 2008 06:03 
Daniel P. Berrange26 Mar 2008 06:22 
Kevin Wolf26 Mar 2008 06:54.patch
Keir Fraser26 Mar 2008 07:02 
Kevin Wolf26 Mar 2008 07:07 
Keir Fraser26 Mar 2008 07:15 
Kevin Wolf26 Mar 2008 07:22 
Kevin Wolf27 Mar 2008 02:55.patch
Subject:Re: [Xen-devel] The two image formats called qcow
From:Keir Fraser (keir@eu.citrix.com)
Date:03/26/2008 07:15:27 AM
List:com.xensource.lists.xen-devel

On 26/3/08 14:07, "Kevin Wolf" <kwo@suse.de> wrote:

Can we really tack an 'extended header' into a public format like qcow?

I didn't introduce this, it was already there in tapdisk. I don't see a problem with it as the start of the L1 table is referenced in the normal qcow header. qemu-img sets this to something like 0x48 which is immediately after the header, tapdisk uses 0x1000 and gains some unused space for things like the extended header. This is compatible with the qcow implementation of qemu/ioemu.

On the other hand, I could simply strip that extended header (i.e. overwrite the magic with 0x0) after having fixed the image. Then it wouldn't be detected as broken on the next start as well.

Oh, I see. I think it's fine as it is then. Is there any reason not to paste this fixup code into tapdisk too?

-- Keir