43 messages in org.kernel.vger.linux-kernelRe: Linux 2.6.27.27| From | Sent On | Attachments |
|---|---|---|
| Greg KH | Jul 19, 2009 9:06 pm | |
| Greg KH | Jul 19, 2009 9:07 pm | |
| Krzysztof Oledzki | Jul 20, 2009 4:51 am | |
| Greg KH | Jul 20, 2009 8:09 am | |
| Linus Torvalds | Jul 20, 2009 9:00 am | |
| Krzysztof Oledzki | Jul 20, 2009 2:44 pm | |
| Linus Torvalds | Jul 20, 2009 3:07 pm | |
| Marc Dionne | Jul 20, 2009 4:47 pm | |
| Linus Torvalds | Jul 20, 2009 4:56 pm | |
| Marc Dionne | Jul 20, 2009 5:37 pm | |
| Linus Torvalds | Jul 20, 2009 6:01 pm | |
| Linus Torvalds | Jul 20, 2009 6:04 pm | |
| Marc Dionne | Jul 20, 2009 7:38 pm | |
| Krzysztof Oledzki | Jul 20, 2009 11:33 pm | |
| Krzysztof Oledzki | Jul 20, 2009 11:40 pm | |
| Krzysztof Oledzki | Jul 21, 2009 3:15 am | |
| Linus Torvalds | Jul 21, 2009 9:11 am | |
| Linus Torvalds | Jul 21, 2009 12:15 pm | |
| Troy Moure | Jul 21, 2009 2:33 pm | |
| Linus Torvalds | Jul 21, 2009 5:52 pm | |
| Linus Torvalds | Jul 21, 2009 6:07 pm | |
| Linus Torvalds | Jul 21, 2009 6:16 pm | |
| Troy Moure | Jul 21, 2009 11:15 pm | |
| Krzysztof Oledzki | Jul 22, 2009 1:11 am | |
| Krzysztof Oledzki | Jul 22, 2009 1:31 am | |
| Krzysztof Oledzki | Jul 22, 2009 2:55 am | |
| Jens Rosenboom | Jul 22, 2009 2:57 am | |
| Troy Moure | Jul 22, 2009 3:23 am | |
| Troy Moure | Jul 22, 2009 3:26 am | |
| Dick Streefland | Jul 22, 2009 3:32 am | |
| Krzysztof Oledzki | Jul 22, 2009 3:44 am | |
| Krzysztof Oledzki | Jul 22, 2009 3:54 am | |
| Krzysztof Oledzki | Jul 22, 2009 4:49 am | |
| Henrique de Moraes Holschuh | Jul 22, 2009 6:26 am | |
| Krzysztof Oledzki | Jul 22, 2009 6:45 am | |
| Krzysztof Oledzki | Jul 22, 2009 6:48 am | |
| Ian Lance Taylor | Jul 22, 2009 8:35 am | |
| Linus Torvalds | Jul 22, 2009 8:48 am | |
| Linus Torvalds | Jul 22, 2009 8:58 am | |
| Krzysztof Olędzki | Jul 23, 2009 10:33 am | |
| Greg KH | Jul 24, 2009 2:13 pm | |
| Pavel Machek | Jul 29, 2009 7:56 am | |
| Linus Torvalds | Jul 29, 2009 8:58 am |
| Subject: | Re: Linux 2.6.27.27 | |
|---|---|---|
| From: | Linus Torvalds (torv...@linux-foundation.org) | |
| Date: | Jul 22, 2009 8:48:25 am | |
| List: | org.kernel.vger.linux-kernel | |
On Wed, 22 Jul 2009, Krzysztof Oledzki wrote:
On Tue, 21 Jul 2009, Linus Torvalds wrote:
IOW, like this.
Yeah, I'm a moron. Not at _all_ like that. I wish I hadn't sent out the patch, you'd have done it correctly by hand from my description.
diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c index 5c1a2c0..af4a15c 100644 --- a/drivers/video/fbmon.c +++ b/drivers/video/fbmon.c @@ -256,8 +256,8 @@ static void fix_edid(unsigned char *edid, int fix)
static int edid_checksum(unsigned char *edid) { - unsigned char i, csum = 0, all_null = 0; - int err = 0, fix = check_edid(edid); + unsigned csum = 0, all_null = 0; + int i, err = 0, fix = check_edid(edid);
I don't know where the 'char' disappeared, but that was obviously not intended. I just meant to move the 'i' from one line to the other.
if (fix) fix_edid(edid, fix);
Tested-by: Krzysztof Piotr Oledzki <ol...@ans.pl>
On condition, that you keep "unsigned char" here. ;)
Indeed. I'll commit the fixed version. Thanks for testing and sorry for the idiot patch.
Linus
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majo...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/