4 messages in ru.sysoev.nginxRe: diff for opening files with O_NOA...
FromSent OnAttachments
Yusuf GoolamabbasAug 31, 2006 8:18 pm.diff
Igor SysoevAug 31, 2006 10:06 pm 
Yusuf GoolamabbasSep 1, 2006 1:51 am.diff
Igor SysoevSep 1, 2006 2:58 am 
Actions with this message:
Paste this link in email or IM:
Paste this link in email or IM:
Atom feed for this thread
Paste this URL into your reader:
Subject:Re: diff for opening files with O_NOATIMEActions...
From:Yusuf Goolamabbas (yusu@public.gmane.org)
Date:Sep 1, 2006 1:51:42 am
List:ru.sysoev.nginx
Attachments:

Igor, Does attached patch work better for you. I specifically only modify the open call ngx_http_static_module.c

On 9/1/06, Igor Sysoev <is-G@public.gmane.org> wrote:

On Fri, 1 Sep 2006, Yusuf Goolamabbas wrote:

Linux since 2.6.8 supports O_NOATIME in open(2). This does not update the file last access time (st_atime in the inode) when the file is read(2). Cherokee <http://www.0x50.org/> does similar things

This might help in static file serving so I cooked up this patch. I did a grep -r RDONLY in the nginx src and didn't think there were issues if atime updates were disabled for various cases or should I create a patch specific to ngx_http_static_module.c

I think it's better to #define NGX_NOATIME and to set it explicitly. Thank you.

Igor Sysoev http://sysoev.ru/en/