1 message in com.xensource.lists.xen-devel[Xen-devel] [PATCH] Fix xm save command
FromSent OnAttachments
Masaki Kanno27 Feb 2008 01:26.patch
Subject:[Xen-devel] [PATCH] Fix xm save command
From:Masaki Kanno (kann@jp.fujitsu.com)
Date:02/27/2008 01:26:35 AM
List:com.xensource.lists.xen-devel
Attachments:

Hi,

When I didn't give a necessary argument to xm save command, I saw the following error message.

# xm save -c vm1 Unexpected error: exceptions.IndexError

Please report to xen-@lists.xensource.com Traceback (most recent call last): File "/usr/sbin/xm", line 10, in ? main.main(sys.argv) File "/usr/lib/python/xen/xm/main.py", line 2594, in main _, rc = _run_cmd(cmd, cmd_name, args) File "/usr/lib/python/xen/xm/main.py", line 2618, in _run_cmd return True, cmd(args) File "/usr/lib/python/xen/xm/main.py", line 703, in xm_save savefile = params[1] IndexError: list index out of range

This patch fixes the problem. A test result is as follows.

# xm save -c vm1 Error: Wrong number of parameters Usage: xm save [-c] <Domain> <CheckpointFile>

Save a domain state to restore later. -c, --checkpoint Leave domain running after creating snapshot

And the following sys.exit(1) is not necessary because sys.exit(1) is executed in usage().

@@ -710,9 +707,9 @@ def xm_save(args): if len(params) != 2: err("Wrong number of parameters") usage('save') - sys.exit(1)

Signed-off-by: Masaki Kanno <kann@jp.fujitsu.com>

Best regards, Kan