atom feed122 messages in com.xensource.lists.xen-develRE: [Xen-devel] Re: APIC rework
FromSent OnAttachments
36 earlier messages
Konrad Rzeszutek WilkSep 24, 2009 5:43 am 
Christian TramnitzSep 24, 2009 6:19 am 
Andy BurnsSep 24, 2009 10:46 am 
Jeremy FitzhardingeSep 24, 2009 11:22 am 
Thiago Camargo Martins CordeiroSep 24, 2009 11:29 am 
Patrick ScharrenbergSep 24, 2009 12:11 pm 
Thiago Camargo Martins CordeiroSep 24, 2009 12:31 pm 
Jeremy FitzhardingeSep 24, 2009 12:37 pm 
Jeremy FitzhardingeSep 24, 2009 12:55 pm 
Jeremy FitzhardingeSep 24, 2009 1:00 pm 
Konrad Rzeszutek WilkSep 24, 2009 2:35 pm 
Zhang, XiantaoSep 24, 2009 6:43 pm 
Pasi KärkkäinenOct 11, 2009 8:38 am 
Konrad Rzeszutek WilkOct 12, 2009 1:02 pm 
Pasi KärkkäinenOct 14, 2009 2:13 pm 
Konrad Rzeszutek WilkOct 15, 2009 1:03 pm 
Boris DerzhavetsOct 16, 2009 12:47 am.gz
Pasi KärkkäinenOct 16, 2009 2:01 am 
Konrad Rzeszutek WilkOct 20, 2009 9:57 am.patch
Pasi KärkkäinenOct 21, 2009 4:53 am 
Konrad Rzeszutek WilkOct 21, 2009 11:31 am 
Pasi KärkkäinenOct 21, 2009 11:51 am 
Jeremy FitzhardingeOct 21, 2009 12:49 pm 
Pasi KärkkäinenOct 21, 2009 1:21 pm 
Pasi KärkkäinenOct 27, 2009 8:46 am 
Konrad Rzeszutek WilkOct 27, 2009 9:59 am.makefile, .c
Pasi KärkkäinenOct 27, 2009 10:29 am 
Konrad Rzeszutek WilkOct 27, 2009 12:40 pm 
Pasi KärkkäinenOct 27, 2009 12:45 pm 
Konrad Rzeszutek WilkOct 27, 2009 1:12 pm 
Pasi KärkkäinenOct 27, 2009 1:17 pm 
Pasi KärkkäinenOct 27, 2009 1:23 pm 
Pasi KärkkäinenOct 27, 2009 1:35 pm 
Jeremy FitzhardingeNov 11, 2009 4:46 pm 
Jeremy FitzhardingeNov 11, 2009 4:59 pm 
Jeremy FitzhardingeNov 12, 2009 3:50 pm 
Zhang, XiantaoNov 12, 2009 9:26 pm 
Keir FraserNov 12, 2009 11:24 pm 
Jeremy FitzhardingeNov 13, 2009 3:56 pm 
Keir FraserNov 14, 2009 12:04 am 
Zhang, XiantaoNov 16, 2009 2:37 am.patch, .patch
Jeremy FitzhardingeNov 16, 2009 10:37 am 
Zhang, XiantaoNov 16, 2009 7:12 pm 
Keir FraserNov 16, 2009 7:44 pm 
Jeremy FitzhardingeNov 16, 2009 9:12 pm 
Jeremy FitzhardingeNov 16, 2009 9:19 pm 
Keir FraserNov 16, 2009 9:43 pm 
Zhang, XiantaoNov 17, 2009 4:45 am.patch
Keir FraserNov 17, 2009 5:04 am 
Zhang, XiantaoNov 17, 2009 6:16 am 
Jeremy FitzhardingeNov 17, 2009 10:50 am 
Keir FraserNov 17, 2009 11:49 am 
Jiang, YunhongNov 17, 2009 7:11 pm 
Zhang, XiantaoNov 17, 2009 7:24 pm 
Zhang, XiantaoNov 17, 2009 7:37 pm 
Keir FraserNov 18, 2009 1:36 am 
Konrad Rzeszutek WilkNov 18, 2009 6:14 am 
Konrad Rzeszutek WilkNov 18, 2009 6:29 am 
Zhang, XiantaoNov 19, 2009 5:45 pm 
Zhang, XiantaoNov 19, 2009 5:47 pm 
Zhang, XiantaoNov 24, 2009 2:04 am.patch, .patch
Jeremy FitzhardingeNov 24, 2009 11:25 am 
Konrad Rzeszutek WilkNov 24, 2009 11:43 am 
Jeremy FitzhardingeNov 24, 2009 3:34 pm 
Zhang, XiantaoNov 24, 2009 5:41 pm 
Zhang, XiantaoNov 24, 2009 6:43 pm 
Konrad Rzeszutek WilkNov 25, 2009 5:41 am 
Konrad Rzeszutek WilkNov 25, 2009 6:09 am 
Zhang, XiantaoNov 25, 2009 7:21 am 
Konrad Rzeszutek WilkNov 25, 2009 10:00 am 
Jeremy FitzhardingeNov 25, 2009 10:58 am 
Jeremy FitzhardingeNov 25, 2009 11:13 am 
Zhang, XiantaoNov 25, 2009 5:11 pm 
Zhang, XiantaoNov 26, 2009 3:52 am 
Konrad Rzeszutek WilkNov 30, 2009 6:26 am 
Konrad Rzeszutek WilkNov 30, 2009 6:33 am 
Zhang, XiantaoDec 2, 2009 6:13 pm 
Konrad Rzeszutek WilkDec 3, 2009 6:37 am 
Stefan KuhneDec 4, 2009 8:07 am 
Pasi KärkkäinenDec 4, 2009 10:57 am 
Jeremy FitzhardingeDec 4, 2009 11:26 am 
Pasi KärkkäinenJan 1, 2010 9:20 am 
Konrad Rzeszutek WilkJan 4, 2010 5:37 am 
Pasi KärkkäinenJan 4, 2010 11:41 am 
Konrad Rzeszutek WilkJan 14, 2010 12:05 pm 
Pasi KärkkäinenJan 14, 2010 11:18 pm 
Subject:RE: [Xen-devel] Re: APIC rework
From:Zhang, Xiantao (xian@intel.com)
Date:Nov 17, 2009 6:16:34 am
List:com.xensource.lists.xen-devel

Keir Fraser wrote:

On 17/11/2009 12:46, "Zhang, Xiantao" <xian@intel.com> wrote:

If Xen can set the interrupt triggering by itself, why would it ever need dom0 to do it? Couldn't it just preconfigure all the pins, and then wait for dom0 to provide/request the pirq<->evtchn mapping?

After reviewing the logic, I think we can use DOMID_SELF to identify new dom0. In linux-2.6.18 dom0, only qemu uses this hypercall for device assginment, so map->domid shouldn't be dom0. If old dom0/qemu with this hypercall, keeps the logic unchanged, and only change the logic for new dom0 when call into it. Attached the patch.

Don't like it (subtle semantic difference based on domid field is very odd and could bite us later), and actually now I look closer I don't like the original patch much either, if only because it does clearly change the interface for MAP_PIRQ_TYPE_GSI by adding trigger/polarity flags (and not documented or exported properly in the physdev.h header file).

I need to take a step back and work out what in fact you're trying to achieve. I'm going to revert the original patch from xen-unstable. If such an interface extension is really required, I think at least the new interface should be a new subtype of MAP_PIRQ_TYPE_xxx, properly described in the header file. But like I say, I don't know what the patch is even really trying to do or overcome.

Originally, this patch is target to get rid of ioapic changes in dom0. Before
this patch, GSI irq should be mapped and setup through dom0 programming ioapic
entries, but it depends on using ioapic logic in dom0. And if we remove ioapic
logic from dom0, we need to find new way how to setup GSI irq. And this patch
comes out under this situation. The idea is from that in Xen the interface
MAP_PIRQ_TYPE_MSI is used to build the pirq and irq mapping for MSI IRQ for each
domain. Since MSI IRQ can be setup through this hypercall, and I think we also
can leverage the interface MAP_PIRQ_TYPE _GSI to build the mapping for GSI irq.
Further analysis showes that this interface is only used for assigning devices
to HVM domain in qemu, and I think it should be Okay for dom0 building the
mapping between its pirq and irq. One different thing for GSI irq is that more
info should be provided in the call, since GSI IRQ has different trigger-mode
and polarity (originally it is provided by ioapic write in dom0). Certainly, I
also think we need to document the related info, and if you agree to the change,
I am happy to add it. Xiantao