Hello Brian,
On Wed, 24 May 2006, Brian Candler wrote:
On Tue, May 23, 2006 at 10:02:42AM +0200, Marcin Semeniuk wrote:
BTW, don't you think that using styles in *.c files is better than using
hardcoded
attributes (for example font names, colors, etc.) ?
I remember this being discussed a while ago. IIRC, at the time Sam wanted to
do it that way for compatibility with old browsers which didn't support CSS,
or supported it badly.
That was a couple of years ago I think, and these 'old' browsers can be
reclassified as 'ancient'. I think it would now be good to completely
separate the style from the content, a la www.csszengarden.com. This would
allow virtual domain owners to perform almost all the customisation they
could want just by adding a cascaded stylesheet, with very low risk that
things would break when sqwebmail was upgraded to a new version.
It's a very good idea. I like it :) I also propose to add a new
environment variable (for example SQWEBMAIL_CSSFILE), for dynamic
setting of CSS file. In my opinion it can be a good complement for
the SQWEBMAIL_TEMPLATEDIR variable. Now if I want to have the same
templates, but with the different styles (for example with default,
bigger and the biggest fonts), I have to multiply templates.
The main issue would be with the rounded corner boxes, but personally I
wouldn't mind if they were lost.
I propose to create the template variables for setting a look of box
corners, for example BOX_BEGIN and BOX_END. If you don't like the
rounded corner boxes, you could set
[#$BOX_BEGIN=<table class="box"><tr><td>#]
[#$BOX_END=</td></tr></table>#]
My best regards,