48 messages in net.launchpad.lists.openstackRe: [Openstack] best practices for me...| From | Sent On | Attachments |
|---|---|---|
| Andrew Bogott | Jul 2, 2012 12:16 pm | |
| Russell Bryant | Jul 2, 2012 12:26 pm | |
| Joshua Harlow | Jul 2, 2012 2:41 pm | |
| Joshua Harlow | Jul 2, 2012 2:54 pm | |
| Gabriel Hurley | Jul 2, 2012 3:18 pm | |
| John Postlethwait | Jul 2, 2012 4:42 pm | |
| Christopher B Ferris | Jul 2, 2012 5:41 pm | |
| Thierry Carrez | Jul 3, 2012 2:31 am | |
| Thierry Carrez | Jul 3, 2012 2:34 am | |
| Doug Hellmann | Jul 3, 2012 5:37 am | |
| James E. Blair | Jul 3, 2012 6:55 am | |
| Joshua Harlow | Jul 3, 2012 10:46 am | |
| Dan Prince | Jul 3, 2012 10:59 am | |
| Gabriel Hurley | Jul 3, 2012 11:59 am | |
| Andrew Bogott | Jul 3, 2012 12:47 pm | |
| Joshua Harlow | Jul 3, 2012 2:09 pm | |
| James E. Blair | Jul 3, 2012 2:54 pm | |
| Eric Windisch | Jul 3, 2012 3:47 pm | |
| Andrew Bogott | Jul 3, 2012 3:54 pm | |
| Gabriel Hurley | Jul 3, 2012 4:53 pm | |
| Timothy Daly | Jul 3, 2012 5:27 pm | |
| Monty Taylor | Jul 3, 2012 6:17 pm | |
| Thierry Carrez | Jul 4, 2012 2:56 am | |
| Gabriel Hurley | Jul 4, 2012 3:17 pm | |
| Eric Windisch | Jul 4, 2012 4:11 pm | |
| Christopher B Ferris | Jul 5, 2012 4:29 am | |
| Sean Dague | Jul 5, 2012 6:55 am | |
| Doug Hellmann | Jul 5, 2012 7:16 am | |
| Joshua Harlow | Jul 5, 2012 10:21 am | |
| Mark McLoughlin | Jul 18, 2012 2:01 am | |
| Mark McLoughlin | Jul 18, 2012 2:13 am | |
| Mark McLoughlin | Jul 18, 2012 2:16 am | |
| Mark McLoughlin | Jul 18, 2012 2:23 am | |
| Thierry Carrez | Jul 18, 2012 4:00 pm | |
| Doug Hellmann | Jul 23, 2012 8:50 am | |
| Thierry Carrez | Jul 23, 2012 8:59 am | |
| Doug Hellmann | Jul 23, 2012 9:04 am | |
| Eric Windisch | Aug 2, 2012 1:05 pm | |
| Christopher B Ferris | Aug 2, 2012 2:08 pm | |
| Vishvananda Ishaya | Aug 2, 2012 3:47 pm | |
| Jay Pipes | Aug 2, 2012 5:18 pm | |
| Zhongyue Luo | Aug 2, 2012 5:24 pm | |
| Eric Windisch | Aug 2, 2012 5:51 pm | |
| Mark McLoughlin | Aug 2, 2012 10:26 pm | |
| Thierry Carrez | Aug 3, 2012 2:49 am | |
| Thierry Carrez | Aug 3, 2012 4:02 am | |
| Jay Pipes | Aug 3, 2012 9:25 am | |
| Eric Windisch | Aug 3, 2012 9:34 am |
| Subject: | Re: [Openstack] best practices for merging common into specific projects | |
|---|---|---|
| From: | Andrew Bogott (abog...@wikimedia.org) | |
| Date: | Jul 3, 2012 3:54:06 pm | |
| List: | net.launchpad.lists.openstack | |
On 7/3/12 5:47 PM, Eric Windisch wrote:
git submodules don't have to be linked to the head of a branch. Instead of double-commiting (for every commit), we can do a single commit in each project to change the git reference of the submodule. This would not be too far from the existing behavior, except that it would minimize the double commits.
Oh, I guess I left out an important part of my vision, which is that there would be a commit hook in common which moves the submodule reference in the parent projects anytime a patch is merged in common. So, in short: once a patch passed review for inclusion in common, that patch would automatically go live in all other project heads simultaneously.
-- Eric Windisch
On Tuesday, July 3, 2012 at 15:47 PM, Andrew Bogott wrote:
On 7/3/12 1:59 PM, Gabriel Hurley wrote:
The notion that copying code is any protection against APIs that may change is a red herring. It's the exact same effect as pegging a version of a dependency (whether it's a commit hash or a real version number), except now you have code duplication. An unstable upgrade path is an unstable upgrade path, and copying the code into the project doesn't alleviate the pain for the project if the upstream library decides to change its APIs.
Also, we're really calling something used by more or less all the core projects "incubated"? ;-) Seems like it's past the proof-of-concept phase now, at least for many parts of common. Questions of API stability are an issue unto themselves.
Anyhow, I'm +1 on turning it into a real library of its own, as a couple people suggested already.
- Gabriel
I feel like I should speak up since I started this fight in the first place :)
Like most people in this thread, I too long for an end to the weird double-commit process that we're using now. So I'm happy to set aside my original Best Practices proposal until there's some consensus regarding how much longer we're going to use that process. Presumably opinions about how to handle merge-from-common commits will vary in the meantime, but that's something we can live with.
In terms of promoting common into a real project, though, I want to raise another option that's guaranteed to be unpopular: We make openstack-common a git-submodule that is automatically checked out within the directory tree of each other project. Then each commit to common would need to be gated by the full set of tests on every project that includes common.
I haven't thought deeply about the pros and cons of code submodule vs. python project, but I want to bring up the option because it's the system that I'm the most familiar with, and one that's been discussed a bit off and on.
-Andrew
_______________________________________________ Mailing list: https://launchpad.net/~openstack <https://launchpad.net/%7Eopenstack> Post to : open...@lists.launchpad.net <mailto:open...@lists.launchpad.net> Unsubscribe : https://launchpad.net/~openstack <https://launchpad.net/%7Eopenstack> More help : https://help.launchpad.net/ListHelp
_______________________________________________ Mailing list: https://launchpad.net/~openstack Post to : open...@lists.launchpad.net Unsubscribe : https://launchpad.net/~openstack More help : https://help.launchpad.net/ListHelp