22 messages in org.freebsd.freebsd-portsRe: Mk/bsd.command.mk: missing CSH tag| From | Sent On | Attachments |
|---|---|---|
| O. Hartmann | Nov 18, 2010 5:19 am | |
| Eir Nym | Nov 18, 2010 6:21 am | |
| Jason Helfman | Nov 18, 2010 8:07 am | |
| Eir Nym | Nov 18, 2010 8:12 am | |
| Rob Farmer | Nov 18, 2010 9:18 am | |
| Eir Nym | Nov 18, 2010 9:24 am | |
| Jason Helfman | Nov 18, 2010 9:39 am | |
| Rob Farmer | Nov 18, 2010 9:59 am | |
| Eir Nym | Nov 18, 2010 10:08 am | |
| Rob Farmer | Nov 18, 2010 10:39 am | |
| Christian Weisgerber | Nov 19, 2010 5:44 am | |
| Eir Nym | Nov 19, 2010 6:03 am | |
| Anonymous | Nov 19, 2010 6:26 am | |
| Eir Nym | Nov 19, 2010 6:31 am | |
| Christian Weisgerber | Nov 19, 2010 7:31 am | |
| Eir Nym | Nov 19, 2010 8:05 am | |
| Matthew D. Fuller | Nov 19, 2010 9:09 am | |
| Eir Nym | Nov 19, 2010 9:21 am | |
| Anonymous | Nov 19, 2010 9:47 am | |
| Eir Nym | Nov 19, 2010 11:47 am | |
| Lars Engels | Nov 22, 2010 6:16 am | |
| Eir Nym | Nov 22, 2010 3:26 pm |
| Subject: | Re: Mk/bsd.command.mk: missing CSH tag | |
|---|---|---|
| From: | Eir Nym (eir...@gmail.com) | |
| Date: | Nov 18, 2010 9:24:40 am | |
| List: | org.freebsd.freebsd-ports | |
On 18 November 2010 20:18, Rob Farmer <rfar...@predatorlabs.net> wrote:
On Thu, Nov 18, 2010 at 08:13, Eir Nym <eir...@gmail.com> wrote:
On 18 November 2010 19:08, Jason Helfman <jhel...@e-e.com> wrote:
Wrote a quick patch: --- bsd.commands.mk.orig 2010-11-18 08:05:47.000000000 -0800 +++ bsd.commands.mk 2010-11-18 08:06:17.000000000 -0800 @@ -76,6 +76,7 @@ SED?= /usr/bin/sed SETENV?= /usr/bin/env SH?= /bin/sh +CSH?= /bin/csh SORT?= /usr/bin/sort STRIP_CMD?= /usr/bin/strip # Command to run commands as privileged user
The patch should probably retain alphabetical order.
Your patch should check if tcsh is in system. it is optional component.
Why? What do you suggest happens if it isn't found? Nothing will break except stuff that uses the variable and it would use the variable because it needs csh. It is part of the base system (/bin/csh and /bin/tcsh) for all supported releases.
Firstly, it is optional part. and I can rewrite build script to make(1) or at least shell script
-- Rob Farmer
_______________________________________________ free...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "free...@freebsd.org"