Hello Sam,
On Fri, 21 Jul 2006, Sam Varshavchik wrote:
Pawel Tecza writes:
Hi Sam,
At first, thanks a lot for applying my previous patch!
Now I've made small improvements for "Edit Autoreplies" page:
1. added title of autoreply like for "Address Book" page
2. hardcoded <textarea> tag moved to autoresponder.html
template file and added "class" attribute for it
3. added "class" attribute for <select> tag
There's a problem with converting [#select:name] to <select>.
The reason the current select is done this way is because you need it in
order for the HTML templates to be editable by the Amaya HTML editor.
Right now, the existing HTML is valid. With your change, it's broken HTML,
because there's non-empty content outside of the <option> tag.
Sorry, but I don't use Amaya, so I didn't care about XHTML validation
of template files. I was thinking that XHTML validation of HTML files
which were generated by Sqwebmail is important.
I'll apply this patch, but without the <select> chunk.
OK, I've added support for 'class' attribute of dynamic converted
<select> tag. Now it has [#select:name:class:size#] syntax,
where 'class' and 'size' attributes are optional.
This is my patch:
Index: webmail/sqwebmail.c
===================================================================
RCS file: /cvsroot/courier/courier/webmail/sqwebmail.c,v
retrieving revision 1.137
diff -u -r1.137 sqwebmail.c
--- webmail/sqwebmail.c 7 Jul 2006 23:17:18 -0000 1.137
+++ webmail/sqwebmail.c 24 Jul 2006 14:32:50 -0000
@@ -1583,9 +1583,11 @@
else if (strncmp(kw, "select:", 7) == 0)
{
const char *name=strtok(kw+7, ":");
+ const char *class=strtok(0, ":");
const char *size=strtok(0, ":");
printf("<select name=\"%s\"", name ? name:"");
+ if (class) printf(" class=\"%s\"", class);
if (size) printf(" size=\"%s\"", size);
printf(">");
}
Index: webmail/html/en-us/autoresponder.html
===================================================================
RCS file: /cvsroot/courier/courier/webmail/html/en-us/autoresponder.html,v
retrieving revision 1.20
diff -u -r1.20 autoresponder.html
--- webmail/html/en-us/autoresponder.html 22 Jul 2006 02:48:15 -0000 1.20
+++ webmail/html/en-us/autoresponder.html 24 Jul 2006 14:33:05 -0000
@@ -102,7 +102,7 @@
</tr>
<tr>
<td align="right">Existing autoreplies:</td>
-
<td>[#select:autoresponse_choose#][#option:#][#endoption#][#AUTORESPONSE_LIST#][#endselect#]
+
<td>[#select:autoresponse_choose:autoresplist#][#option:#][#endoption#][#AUTORESPONSE_LIST#][#endselect#]
<input type="submit" value="Edit" name="do.autorespedit" />
<input type="submit" value="Delete"
name="do.autorespdelete" /></td>
My best regards,
PS. You didn't guess my next patch ;)
6 messages in net.sourceforge.lists.courier-sqwebmailRe: [sqwebmail] Small "Edit Autorepli...
.gz
