atom feed29 messages in net.java.dev.phoneme.advancedRe: Code review for new code submissi...
FromSent OnAttachments
Hinkmond WongApr 24, 2008 6:05 pm 
Danila SinopalnikovApr 25, 2008 1:41 am 
Davy PreuveneersApr 25, 2008 2:45 am 
Danila SinopalnikovApr 25, 2008 3:08 am 
Jiangli ZhouApr 25, 2008 9:55 am 
Davy PreuveneersMay 5, 2008 2:48 am.diff
Stephen FloresMay 8, 2008 7:41 pm 
Jiangli ZhouMay 12, 2008 11:44 am 
Davy PreuveneersMay 13, 2008 1:01 am 
Jiangli ZhouMay 13, 2008 9:25 am 
Davy PreuveneersMay 13, 2008 12:06 pm.diff
Stephen FloresMay 13, 2008 6:48 pm 
phon...@mobileandembedded.orgMay 23, 2008 6:16 pm 
Davy PreuveneersMay 24, 2008 1:14 am.diff, .diff, .diff, 3 more
phon...@mobileandembedded.orgMay 27, 2008 5:25 pm 
phon...@mobileandembedded.orgJun 4, 2008 6:26 pm 
phon...@mobileandembedded.orgJun 14, 2008 1:13 pm 
phon...@mobileandembedded.orgJun 14, 2008 9:18 pm 
xyzzy (Dean)Jun 15, 2008 1:42 am 
phon...@mobileandembedded.orgJun 15, 2008 3:16 am 
xyzzy (Dean)Jun 16, 2008 12:47 pm 
phon...@mobileandembedded.orgJun 16, 2008 1:56 pm 
phon...@mobileandembedded.orgJun 16, 2008 3:36 pm 
phon...@mobileandembedded.orgJun 16, 2008 3:55 pm 
phon...@mobileandembedded.orgJun 16, 2008 3:56 pm 
Hinkmond WongJun 16, 2008 3:57 pm 
phon...@mobileandembedded.orgJun 16, 2008 4:24 pm 
phon...@mobileandembedded.orgJun 16, 2008 4:33 pm 
phon...@mobileandembedded.orgAug 22, 2008 9:50 pm 
Subject:Re: Code review for new code submission from Davy Preuveneers (4/24/2008)
From:phon...@mobileandembedded.org (phon@mobileandembedded.org)
Date:Jun 4, 2008 6:26:52 pm
List:net.java.dev.phoneme.advanced

Davy sent me an update to his Alert.diff. Please code review this:

-Alert: Clean up the code by using macros instead of numbers https://phoneme.dev.java.net/nonav/issues/showattachment.cgi/24/davyp-20080604-Alert.rev11498.diff

For reference, here are the other diffs from Davy that along with the above diff
I will be putting on a branch for build and runtime testing:

-AwtPPC and AwtPPCStubs: replaced empty clearBackground() method in PPCComponentPeer.java with one with an implementation. Changed offset of AWT frame so that the top window bar does not hide part of the frame. https://phoneme.dev.java.net/nonav/issues/showattachment.cgi/25/davyp-20080604-AwtPPC.rev11420.diff https://phoneme.dev.java.net/nonav/issues/showattachment.cgi/26/davyp-20080604-AwtPPCStubs.rev11420.diff

-CLDC: removed redundant VS2005 test so that flag also works with eVC4 https://phoneme.dev.java.net/nonav/issues/showattachment.cgi/27/davyp-20080604-CLDC.rev11420.diff https://phoneme.dev.java.net/nonav/issues/showattachment.cgi/28/davyp-20080604-MIDP.rev11420.diff

-Suite: Restructured original patch https://phoneme.dev.java.net/nonav/issues/showattachment.cgi/29/davyp-20080604-Suite.rev11420.diff

Please let me or Davy know if you have any questions or issues with the above
planned code diffs for committing to the phoneME repository.

Thanks, Hinkmond [Message sent by forum member 'hinkmond' (hinkmond)]

http://forums.java.net/jive/thread.jspa?messageID=278445