6 messages in ru.sysoev.nginxRe: find bug in dns resovle
FromSent OnAttachments
ngi...@aqcx.comNov 16, 2008 6:20 pm 
Igor SysoevNov 16, 2008 11:50 pm 
ngi...@aqcx.comNov 17, 2008 2:02 am 
Robert GabrielNov 18, 2008 1:43 pm 
Igor SysoevNov 18, 2008 1:50 pm 
Robert GabrielNov 18, 2008 11:32 pm 
Actions with this message:
Paste this link in email or IM:
Paste this link in email or IM:
Atom feed for this thread
Paste this URL into your reader:
Subject:Re: find bug in dns resovleActions...
From:Igor Sysoev (is@rambler-co.ru)
Date:Nov 18, 2008 1:50:01 pm
List:ru.sysoev.nginx

On Tue, Nov 18, 2008 at 10:43:32PM +0100, Robert Gabriel wrote:

Igor Sysoev wrote:

On Mon, Nov 17, 2008 at 10:20:34AM +0800, ngi@aqcx.com wrote:

in function ngx_resolver_copy ,n = (n & 0x3f << 8) + *p; should be n = ((n & 0x3f) << 8) + *p;otherwis ,& oprator will not work
correctlly.

Thank you very much. I had missed it as it becomes apparent on big (>256 bytes) DNS responses. What is your full name to include in CHANGES log ?

Isnt the same idea of n = (n & 0x3f << 8) + *src;

should this be:

n = ((n & 0x3f << 8) + *src);

Sorry I might be wrong... but who knows :P

This is the same.

-- Igor Sysoev http://sysoev.ru/en/