42 messages in org.freebsd.freebsd-fsRe: [review request] zfsboot/zfsloade...| From | Sent On | Attachments |
|---|---|---|
| Andriy Gapon | Apr 14, 2012 8:37 am | |
| Andriy Gapon | Apr 14, 2012 10:35 am | |
| Bob Friesenhahn | Apr 14, 2012 6:00 pm | |
| Garrett Cooper | Apr 14, 2012 7:30 pm | |
| John Baldwin | Apr 16, 2012 6:55 am | |
| vermaden | Apr 16, 2012 10:34 pm | |
| Andriy Gapon | Apr 17, 2012 1:21 pm | |
| John Baldwin | Apr 17, 2012 1:43 pm | |
| Andriy Gapon | Apr 17, 2012 11:01 pm | |
| Andriy Gapon | Apr 18, 2012 1:57 am | |
| Andriy Gapon | Apr 18, 2012 2:18 am | |
| John Baldwin | Apr 18, 2012 6:41 am | |
| Ian Lepore | Apr 18, 2012 7:22 am | |
| Andriy Gapon | Apr 18, 2012 7:36 am | |
| Ian Lepore | Apr 18, 2012 7:39 am | |
| Andriy Gapon | Apr 18, 2012 7:59 am | |
| John Baldwin | Apr 18, 2012 10:47 am | |
| Marius Strobl | Apr 22, 2012 2:20 pm | |
| Andrey V. Elsukov | Apr 22, 2012 11:23 pm | |
| Andriy Gapon | Apr 27, 2012 2:05 am | |
| Andriy Gapon | Apr 27, 2012 2:13 am | |
| Andrey V. Elsukov | Apr 27, 2012 3:37 am | |
| Andriy Gapon | Apr 27, 2012 7:06 am | |
| Marius Strobl | Apr 29, 2012 9:46 am | |
| Andriy Gapon | Apr 30, 2012 12:03 am | |
| Marius Strobl | May 1, 2012 1:20 pm | |
| Andriy Gapon | May 3, 2012 8:02 am | |
| Andriy Gapon | May 3, 2012 8:23 am | |
| John Baldwin | May 4, 2012 8:24 am | |
| Andriy Gapon | May 5, 2012 2:30 am | |
| Andriy Gapon | May 5, 2012 2:52 am | |
| Bruce Evans | May 5, 2012 3:49 am | |
| John Baldwin | May 7, 2012 6:52 am | |
| Andriy Gapon | May 7, 2012 7:34 am | |
| Andriy Gapon | May 7, 2012 7:46 am | |
| Andriy Gapon | May 7, 2012 8:15 am | |
| John Baldwin | May 7, 2012 10:37 am | |
| John Baldwin | May 7, 2012 10:43 am | |
| Andriy Gapon | May 8, 2012 12:14 am | |
| John Baldwin | May 8, 2012 7:15 am | |
| Andriy Gapon | May 8, 2012 11:34 am | |
| Andriy Gapon | May 11, 2012 3:31 pm |
| Subject: | Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool | |
|---|---|---|
| From: | John Baldwin (jh...@freebsd.org) | |
| Date: | Apr 18, 2012 6:41:01 am | |
| List: | org.freebsd.freebsd-fs | |
On Wednesday, April 18, 2012 2:02:22 am Andriy Gapon wrote:
on 17/04/2012 23:43 John Baldwin said the following:
On Tuesday, April 17, 2012 4:22:19 pm Andriy Gapon wrote:
We already have a flag for ZFS (KARGS_FLAGS_ZFS, 0x4). So the new flag could be named something ZFS-specific (as silly as KARGS_FLAGS_ZFS2) or something more general such as KARGS_FLAGS_32_BYTES meaning that the total size of arguments area is 32 bytes (as opposed to 24 previously).
Does KARGS_FLAGS_GUID work?
I think that's too terse, we already passed a pool guid via the existing argument space. So it should be something like KARGS_FLAGS_ZFS_FS_GUID or KARGS_FLAGS_ZFS_DS_GUID (DS - dataset).
Ah. I do think the flag should indicate that the bootinfo structure is larger, I was assuming you were adding a new GUID field that didn't exist before. I can't think of something better than KARGS_FLAGS_32. What might be nice actually, is to add a new field to indicate the size of the argument area and to set a flag to indicate that the size field is present (KARGS_FLAGS_SIZE)?
Hmm, looks like we should name this structure and move it and the relevant KARGS_FLAGS_* fields into a header while we are at it?
-- John Baldwin
_______________________________________________ free...@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-fs To unsubscribe, send any mail to "free...@freebsd.org"