atom feed2 messages in org.freebsd.freebsd-amd64Re: amd64/144405: [build] [patch] inc...
FromSent OnAttachments
AnonymousJul 15, 2010 3:19 pm 
AnonymousJul 18, 2010 6:39 pm 
Subject:Re: amd64/144405: [build] [patch] include /usr/obj/lib32 in cleanworld target on amd64 arch
From:Anonymous (swel@gmail.com)
Date:Jul 18, 2010 6:39:46 pm
List:org.freebsd.freebsd-amd64

The following reply was made to PR amd64/144405; it has been noted by GNATS.

From: Anonymous <swel@gmail.com> To: Alexander Best <alex@uni-muenster.de> Cc: bug-@freebsd.org Subject: Re: amd64/144405: [build] [patch] include /usr/obj/lib32 in cleanworld
target on amd64 arch Date: Mon, 19 Jul 2010 05:33:37 +0400

Alexander Best <alex@uni-muenster.de> writes:

i can't really think of a situation where somebody wants to remove all the 64bit objs but keep the 32bit ones.

I was concerned about cleanworld invoked by crossbuild breaking normal build when running concurrently but looks like that's not the case, i.e.

$ make cleanworld TARGET=i386 # /usr/obj/i386.i386/lib32/usr/src

doesn't wipe out lib32 for normal build (/usr/obj/lib32/usr/src). Since crossbuild encloses lib32 in its OBJTREE there is no need for MK_LIB32 check.

--- b.diff begins here --- diff --git a/Makefile.inc1 b/Makefile.inc1 index 85669d5..2298eca 100644 --- a/Makefile.inc1 +++ b/Makefile.inc1 @@ -1512,7 +1512,7 @@ cleanworld: -chflags -R 0 ${OBJTREE}${.CURDIR} rm -rf ${OBJTREE}${.CURDIR}/* .endif -.if exists(${OBJTREE}/lib32${.CURDIR}) && ${MK_LIB32} != "no" +.if exists(${OBJTREE}/lib32${.CURDIR}) -rm -rf ${OBJTREE}/lib32${.CURDIR}/* -chflags -R 0 ${OBJTREE}/lib32${.CURDIR} rm -rf ${OBJTREE}/lib32${.CURDIR}/* --- b.diff ends here ---