atom feed4 messages in org.apache.struts.devRe: ModuleConfigImpl holds reference ...
FromSent OnAttachments
David GrahamFeb 4, 2003 7:05 pm 
Mohan KishoreFeb 4, 2003 7:20 pm 
Craig R. McClanahanFeb 4, 2003 7:49 pm 
Robert LelandFeb 5, 2003 6:40 am 
Subject:Re: ModuleConfigImpl holds reference to factory
From:Robert Leland (rlel@apache.org)
Date:Feb 5, 2003 6:40:14 am
List:org.apache.struts.dev

On Tue, 4 Feb 2003, David Graham wrote:

Date: Tue, 04 Feb 2003 20:05:27 -0700 From: David Graham <dgra@hotmail.com> Reply-To: Struts Developers List <stru@jakarta.apache.org> To: stru@jakarta.apache.org Subject: ModuleConfigImpl holds reference to factory

ModuleConfigImpl implements Serializable but the ModuleConfigFactory interface does not. ModuleConfigImpl has a member variable that stores its factory but never actually uses that variable. We have 2 options:

1. Remove the factory variable from ModuleConfigImpl and the constructor that sets it. (my favorite)

+1, I plead guilty. I had noticed that the commons-pool or commons-collections had a pointer back to the factory. So I used that pattern w/o a use case to support it !