63 messages in com.xensource.lists.xen-develRE: [Xen-devel] RFC: [0/2] Remove net...
FromSent OnAttachments
Herbert Xu19 Mar 2007 21:46 
Herbert Xu19 Mar 2007 21:50 
Herbert Xu19 Mar 2007 21:56 
Keir Fraser20 Mar 2007 00:10 
Herbert Xu20 Mar 2007 03:11 
Keir Fraser20 Mar 2007 03:18 
Keir Fraser20 Mar 2007 03:21 
Keir Fraser20 Mar 2007 03:27 
David Edmondson20 Mar 2007 04:49 
Herbert Xu22 Mar 2007 03:50 
Keir Fraser22 Mar 2007 08:40 
Herbert Xu22 Mar 2007 20:17 
Keir Fraser23 Mar 2007 03:32 
Herbert Xu23 Mar 2007 04:41 
Keir Fraser23 Mar 2007 04:46 
Ian Pratt23 Mar 2007 06:23 
Santos, Jose Renato G23 Mar 2007 16:06 
Ian Pratt23 Mar 2007 16:28 
Herbert Xu25 Mar 2007 04:41 
Keir Fraser25 Mar 2007 05:26 
Herbert Xu25 Mar 2007 19:19 
Keir Fraser26 Mar 2007 11:35 
Herbert Xu26 Mar 2007 14:08 
Santos, Jose Renato G26 Mar 2007 16:57.patch, .patch, .patch
Keir Fraser26 Mar 2007 17:33 
Herbert Xu26 Mar 2007 17:35 
Keir Fraser26 Mar 2007 17:45 
Keir Fraser26 Mar 2007 17:46 
Herbert Xu26 Mar 2007 17:52 
Keir Fraser26 Mar 2007 18:02 
Herbert Xu26 Mar 2007 18:07 
Herbert Xu26 Mar 2007 18:16 
Isaku Yamahata26 Mar 2007 20:34 
Isaku Yamahata26 Mar 2007 20:41 
Herbert Xu26 Mar 2007 22:45 
Keir Fraser27 Mar 2007 00:36 
Herbert Xu27 Mar 2007 00:44 
Keir Fraser27 Mar 2007 00:50 
Herbert Xu27 Mar 2007 00:52 
Herbert Xu27 Mar 2007 00:59 
Keir Fraser27 Mar 2007 01:03 
Keir Fraser27 Mar 2007 01:10 
Keir Fraser27 Mar 2007 01:11 
Herbert Xu27 Mar 2007 01:13 
Herbert Xu27 Mar 2007 01:14 
Isaku Yamahata27 Mar 2007 01:15 
Isaku Yamahata27 Mar 2007 01:22 
Keir Fraser27 Mar 2007 01:30 
Herbert Xu27 Mar 2007 02:20 
Keir Fraser27 Mar 2007 02:58 
Herbert Xu27 Mar 2007 03:05 
Herbert Xu27 Mar 2007 03:14 
Keir Fraser27 Mar 2007 03:17 
Keir Fraser27 Mar 2007 03:18 
Herbert Xu27 Mar 2007 03:25 
Keir Fraser27 Mar 2007 03:39 
Herbert Xu27 Mar 2007 04:09 
Herbert Xu27 Mar 2007 04:11 
Ian Pratt27 Mar 2007 06:14 
Keir Fraser27 Mar 2007 06:49 
Herbert Xu27 Mar 2007 13:46 
Herbert Xu28 Mar 2007 06:04 
Isaku Yamahata28 Mar 2007 23:08 
Subject:RE: [Xen-devel] RFC: [0/2] Remove netloop by lazy copying in netback
From:Santos, Jose Renato G (jose@hp.com)
Date:03/26/2007 04:57:38 PM
List:com.xensource.lists.xen-devel
Attachments:

Yep, the approach is similar, but I think having the 'permanent' grants mechanism is probably a bit more flexible for managing the header fragments.

Not sure why it would be more flexible. Do you mean dealing with headers that are in fragments? If headers are in fragments they will be linearized when copied into the shared header area by netfront. Also, it seems to me that having a fixed set of pages at initialization that never change is easier to manage. I probably did not understand you correctly...

It would be good if you could post your patch as it has relevance to what Herbert is currently working on.

Ok. Here are the patches. A few disclaimers. They were not intended to be distributed as is, so there may be some cleanups/optimizations needed, although they were tested on an older version and used to work. They also do not apply cleanly to the current xen-unstable. I am not sure they will be very helpful to Herbert, but since you asked, here they are.

BTW: I'm pretty convinced its time to redefine the net ring format to ensure each fragment has an id, flags, grant, offset and length fields. Things are just getting messy with the current format.

I agree that we will need a new format soon, but I am not sure I understood your concerns above. Currently all fragments do have an id, flag, grant, offset and length fields. Maybe you mean that we need a better way to represent multiple fragments belonging to the same packet.

Any way, the performance analysis that I am doing may indicate that we might need some architectural changes on the device model. I would like to discuss this before we settle on a format. I am trying to get some data in time for the summit, but I am racing the clock...

Regards

Renato

======================== Patches

tx_header_copy: Create and uses set of shared pages between netfront and netback to copy packet headers on network TX path. tx_lazy_map: Do not create a host mapping for packet fragments Tx_handle_page_fault: Handle page fault caused by dom0 trying to access unmapped skb fragment. Creates the mapping in that case

Best, Ian