6 messages in com.xensource.lists.xen-cimRE: [Xen-cim] Patch for review| From | Sent On | Attachments |
|---|---|---|
| Szymanski, Lukasz K | 31 May 2006 14:38 |  .patch |
| Jim Fehlig | 31 May 2006 18:33 | |
| Subrahmanian, Raj | 01 Jun 2006 09:47 | |
| Gareth S Bestor | 01 Jun 2006 10:35 | |
| Gareth S Bestor | 01 Jun 2006 17:23 | |
| Subrahmanian, Raj | 14 Jul 2006 10:35 | .diff |
| Subject: | RE: [Xen-cim] Patch for review |
|---|---|
| From: | Subrahmanian, Raj (raj....@unisys.com) |
| Date: | 07/14/2006 10:35:28 AM |
| List: | com.xensource.lists.xen-cim |
| Attachments: | patch.diff - 3k |
This patch fixes the 'not checking the returns from the CIMOM in References and ReferenceNames' problem. The key name checking is really not necessary to fix this problem. (As an aside, I don't know if any key ties the Host ComputerSystem class and the Virtual (Xen_ComputerSystem) class.) This patch fixes the Xen_HostedComputerSystem file. It is quite trivial to do it for the other classes, but I will wait till the SMASH issue is settled.
Raj
-----Original Message----- From: xen-...@lists.xensource.com [mailto:xen-...@lists.xensource.com] On Behalf Of Jim Fehlig Sent: Wednesday, May 31, 2006 9:34 PM To: Szymanski, Lukasz K Cc: xen-...@lists.xensource.com Subject: Re: [Xen-cim] Patch for review
Szymanski, Lukasz K wrote:
Hello All -
This patch adapts Raj's Xen_HostedComputerSystem patch to other Xen_Hosted* files:
Xen_HostedDisk.mof, Xen_HostedDisk.c, Xen_HostedProcessor.mof, Xen_HostedProcessor.mof, Xen_HostedMemory.mof, Xen_HostedMemory.c, Xen_HostedNetworkPort.mof, Xen_HostedNetworkPort.c
The problem with this patch, and Raj's previous one apparently :-), is that there is no filtering of object paths returned via upcalls to cimom for instance names of the associated thing. For example, in ReferenceNames() in Xen_HostedMemory.c we make an upcall to get all instances of CIM_Memory when it is the target class. But Xen_Memory is a subclass of CIM_Memory so you get instances of Xen_Memory (which is the source class) and associate it with itself or other instances of Xen_Memory for other domains. If I list associations of Xen_Memory for domain 1 using this patch, I get a Xen_HostedMemory association for each Xen_Memory object produced by other domains.
Make sense? I'm quite tired now so this may be a smoked explanation :-).
Thanks, Jim
_______________________________________________ Xen-cim mailing list Xen-...@lists.xensource.com http://lists.xensource.com/xen-cim