2 messages in com.xensource.lists.xen-ia64-develRe: [Xen-ia64-devel] [PATCH][RFC] fix...
FromSent OnAttachments
Isaku Yamahata14 Mar 2007 05:03.patch
Alex Williamson14 Mar 2007 14:51 
Subject:Re: [Xen-ia64-devel] [PATCH][RFC] fix ia64 grant_table destruction
From:Alex Williamson (alex@hp.com)
Date:03/14/2007 02:51:41 PM
List:com.xensource.lists.xen-ia64-devel

On Wed, 2007-03-14 at 21:04 +0900, Isaku Yamahata wrote:

[PATCH][RFC] fix ia64 grant_table destruction. fix type count of grant mapped page for xen/ia64.

This patch is necessary to keep page_info.type_info correctly. However I don't think that this patch is acceptable. Another idea is to modify guest_physmap_remove_page() be aware of grant table mapped page.

Hi Isaku,

I agree, this doesn't feel like the best solution. It's interesting that the comment on cset 8409 (that commented out the line this patch adds back) adds gnttab_release_mappings() after domain_relinquish_resources(). Makes me wonder if the implicit put_page comment is still entirely valid for x86. Thanks,

Alex