19 messages in org.freebsd.freebsd-currentRe: contrib/jemalloc| From | Sent On | Attachments |
|---|---|---|
| Jason Evans | Apr 4, 2012 9:56 pm | |
| John Baldwin | Apr 5, 2012 6:32 am | |
| Konstantin Belousov | Apr 5, 2012 10:52 am | |
| Jason Evans | Apr 5, 2012 11:55 am | |
| Konstantin Belousov | Apr 5, 2012 12:09 pm | |
| Jason Evans | Apr 5, 2012 3:47 pm | |
| David O'Brien | Apr 12, 2012 11:40 am | |
| Jason Evans | Apr 12, 2012 1:19 pm | |
| David O'Brien | Apr 13, 2012 3:42 pm | |
| Jason Evans | Apr 13, 2012 7:34 pm | |
| Doug Barton | Apr 20, 2012 10:33 am | |
| Pedro Giffuni | Apr 20, 2012 11:17 am | |
| Doug Barton | Apr 20, 2012 1:35 pm | |
| Pedro Giffuni | Apr 20, 2012 2:13 pm | |
| Doug Barton | Apr 20, 2012 2:56 pm | |
| David O'Brien | Apr 20, 2012 5:32 pm | |
| Pedro Giffuni | Apr 20, 2012 6:05 pm | |
| Doug Barton | Apr 21, 2012 12:22 am | |
| Pedro Giffuni | Apr 21, 2012 2:19 pm |
| Subject: | Re: contrib/jemalloc | |
|---|---|---|
| From: | Konstantin Belousov (kost...@gmail.com) | |
| Date: | Apr 5, 2012 10:52:21 am | |
| List: | org.freebsd.freebsd-current | |
On Wed, Apr 04, 2012 at 09:56:45PM -0700, Jason Evans wrote:
I have the current version of jemalloc integrated into libc as contrib/jemalloc:
http://people.freebsd.org/~jasone/patches/jemalloc_20120404b.patch
* Are the symbol versioning specifications right, and are the compatibility symbols for _malloc_options and _malloc_message workable?
Why do you manually added __sys_compat() for the symbols ? My reading of the patch shows that you do not change the ABI, and symbols are still at FBSD_1.0 and even in Symbol.map. The 1.3 symbols have different names, without prepended '_' ? Please correct me if I am wrong, but it seems that the __sym_compat() magic is not needed.
* Is the light editing of the jemalloc manual page sufficient? Keeping the changes minimal will make regular imports less work, but the result is less tailored to FreeBSD.
Might be, keep existing but somewhat trimmed malloc(3) page as is, but add the unedited man from contrib as jemalloc(3), xreferencing it from malloc(3) ?