atom feed26 messages in org.freebsd.freebsd-scsiRe: {da,sa,...}open bug?
FromSent OnAttachments
Yar TikhiyNov 22, 2002 10:28 am 
Nate LawsonNov 22, 2002 11:14 am 
Yar TikhiyNov 25, 2002 2:42 am 
Bruce EvansNov 25, 2002 4:28 am 
Yar TikhiyNov 25, 2002 6:05 am 
Nate LawsonNov 25, 2002 12:09 pm 
Nate LawsonNov 25, 2002 12:12 pm 
Bruce EvansNov 25, 2002 10:20 pm 
Yar TikhiyNov 29, 2002 11:37 am 
Nate LawsonDec 1, 2002 4:58 pm 
Yar TikhiyDec 6, 2002 3:59 am 
Nate LawsonDec 6, 2002 11:23 am 
Kenneth D. MerryDec 6, 2002 11:33 am 
Yar TikhiyDec 8, 2002 6:07 am 
Yar TikhiyDec 8, 2002 7:26 am 
Justin T. GibbsDec 8, 2002 10:10 pm 
Nate LawsonDec 9, 2002 1:49 pm 
Nate LawsonDec 9, 2002 1:52 pm 
Yar TikhiyDec 10, 2002 3:39 am 
Yar TikhiyDec 10, 2002 6:15 am 
Yar TikhiyDec 10, 2002 6:33 am 
Nate LawsonDec 10, 2002 1:20 pm 
Nate LawsonDec 10, 2002 1:23 pm 
Nate LawsonDec 10, 2002 1:29 pm 
Yar TikhiyDec 12, 2002 10:56 am 
Nate LawsonDec 13, 2002 10:54 am 
Subject:Re: {da,sa,...}open bug?
From:Yar Tikhiy (ya@FreeBSD.ORG)
Date:Nov 25, 2002 6:05:21 am
List:org.freebsd.freebsd-scsi

On Mon, Nov 25, 2002 at 11:28:31PM +1100, Bruce Evans wrote:

On Mon, 25 Nov 2002, Yar Tikhiy wrote:

While preparing the fix, I noticed an additional couple of oddities. First, files under sys/cam/scsi are inconsistent as to the order of calling cam_periph_release() and cam_periph_unlock(): Some of them will call cam_periph_release() first, and the others will call it second. Then, there's a number of places in the code where cam_periph_unlock() won't be called before return on a cam_periph_acquire() error, though the "periph" has been locked.

I'd like this fixed too. I still have some patches written about 4 years ago for a couple of these reversals. I think things should be unlocked or released in the reverse of the order in which they were locked or acquired, if possible.

I think so, too. If you feel it's OK to push this into 5.0-RELEASE, I'll submit a patch here for review.

To Unsubscribe: send mail to majo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message