atom feed193 messages in net.php.lists.internalsRe: [PHP-DEV] 5.4 again
FromSent OnAttachments
140 earlier messages
Lester CaineMay 11, 2011 3:43 am 
Richard QuadlingMay 11, 2011 4:31 am 
Christian KapsMay 11, 2011 5:21 am 
DrakMay 11, 2011 5:29 am 
Mike van RielMay 11, 2011 5:35 am 
Ferenc KovacsMay 11, 2011 5:52 am 
Lester CaineMay 11, 2011 6:18 am 
Mike van RielMay 11, 2011 6:27 am 
Ferenc KovacsMay 11, 2011 6:31 am 
Lester CaineMay 11, 2011 6:59 am 
Matthew Weier O'PhinneyMay 11, 2011 8:30 am 
Matthew Weier O'PhinneyMay 11, 2011 8:32 am 
Philip OlsonMay 11, 2011 8:42 am 
guil...@gmail.comMay 11, 2011 8:58 am 
guil...@gmail.comMay 11, 2011 9:06 am 
guil...@gmail.comMay 11, 2011 9:21 am 
Christopher JonesMay 11, 2011 9:54 am 
Rasmus LerdorfMay 11, 2011 9:58 am 
Lester CaineMay 11, 2011 10:11 am 
Arvids GodjuksMay 11, 2011 10:18 am 
guil...@gmail.comMay 11, 2011 10:28 am 
Andi GutmansMay 11, 2011 11:03 am 
Ilia AlshanetskyMay 11, 2011 11:14 am 
Johannes SchlüterMay 11, 2011 11:20 am 
Philip OlsonMay 11, 2011 11:33 am 
Martin ScottaMay 11, 2011 11:34 am 
Stas MalyshevMay 11, 2011 11:43 am 
Stas MalyshevMay 11, 2011 11:50 am 
Johannes SchlüterMay 11, 2011 11:54 am 
dukeofgamingMay 11, 2011 12:17 pm 
Stas MalyshevMay 11, 2011 12:30 pm 
Stas MalyshevMay 11, 2011 12:32 pm 
Sebastian BergmannMay 11, 2011 1:55 pm 
Sebastian BergmannMay 11, 2011 1:59 pm 
Sebastian BergmannMay 11, 2011 2:01 pm 
Sebastian BergmannMay 11, 2011 2:05 pm 
Philip OlsonMay 11, 2011 2:10 pm 
Mike van RielMay 11, 2011 2:53 pm 
dukeofgamingMay 11, 2011 2:53 pm 
Rasmus LerdorfMay 11, 2011 2:55 pm 
guil...@gmail.comMay 11, 2011 2:57 pm 
Marcelo GornsteinMay 11, 2011 3:05 pm 
dukeofgamingMay 11, 2011 3:06 pm 
guil...@gmail.comMay 11, 2011 3:14 pm 
Stefan MarrMay 11, 2011 3:20 pm 
Philip OlsonMay 11, 2011 4:28 pm 
Stas MalyshevMay 11, 2011 5:02 pm 
Jordi BoggianoMay 11, 2011 5:55 pm 
Philip OlsonMay 12, 2011 10:29 am 
Alexey SheinMay 13, 2011 7:13 am.txt, .txt
Alexey SheinMay 16, 2011 6:51 am.txt, .txt
Michael MorrisMay 16, 2011 2:16 pm 
Kalle Sommer NielsenMay 16, 2011 2:29 pm 
Subject:Re: [PHP-DEV] 5.4 again
From:Alexey Shein (con@gmail.com)
Date:May 13, 2011 7:13:53 am
List:net.php.lists.internals
Attachments:

Hi, list.

I've fixed some datetime tests in the trunk in answer to "Rasmus call for devs" :) There are two patches here. First patch is quite trivial - it fixes some relative/absolute path misconfiguration in phpt tests. Second patch fixes some timezone errors in bug51819 - some timezones like GB were not parsed correctly. Tests are ok now but don't know if my solution is correct. Hope these patches would be useful.

P.S. Please, note I'm very new to C and will be happy if someone can answer to some of my newbie questions and gently point my mistakes :)

2011/5/12 Rasmus Lerdorf <ras@lerdorf.com>:

On 05/11/2011 02:10 PM, Philip Olson wrote:

So, that's the concern there. But if the alpha is simply a trick to convince people to test out a specific PHP 5.4 snapshot, and feel 5.4 is real, then do it. ;)

There are still quite a few test failures in trunk. Some of them are also in the 5_3 branch. In some cases the tests are simply bad. In a few the test case contains binary data that got mangled in the move to Subversion. It would be nice if just 1 in 10 people reading the list here would grab both trunk and 5_3 and run "make test" in each tree and then fix at least 1 test each. We would have no test failures by the end of the day other than a few tricky ones. If an alpha release will encourage this, great. If we could get people to just do it on their own without the alpha, even better.

And yes, I know the tests take forever to run. Get yourself a fast machine with an SSD, and remember you can run partial tests using:

 make test TESTS=ext/hash

for example to just run the tests for the hash extension.

Also, when a test fails, cd into the ext/hash/tests directory and you will see .out, .exp, .diff and .php files for the failed test. That is, the output, the expected output, the diff between them and the php script itself extracted from the .phpt file containing the failed test case.

And if you can't figure out how to fix a test, post the details here. I'd love to point some of the obvious talents and energy of this list towards the code. If you don't have an svn account for committing your fixed test, go to http://www.php.net/svn-php.php and fill in the little form at the bottom there and put in the test that you fixed and a 1-liner about how you fixed it and I will set you up with an account right away. Info on how to check out the code from svn is here: https://wiki.php.net/vcs/svnfaq

-Rasmus

-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

-- Regards, Shein Alexey

Index: ext/date/tests/DateTime_diff_add_sub-fall-type3-type2.phpt =================================================================== --- ext/date/tests/DateTime_diff_add_sub-fall-type3-type2.phpt (revision 308238) +++ ext/date/tests/DateTime_diff_add_sub-fall-type3-type2.phpt (revision ) @@ -12,7 +12,7 @@ * in a userland package. Please be so kind as to leave them. */

-require './examine_diff.inc'; +require __DIR__ . '/examine_diff.inc'; date_default_timezone_set('America/New_York');

Index: ext/date/tests/DateTime_diff_add_sub-spring-type3-type2.phpt =================================================================== --- ext/date/tests/DateTime_diff_add_sub-spring-type3-type2.phpt (revision
308238) +++ ext/date/tests/DateTime_diff_add_sub-spring-type3-type2.phpt (revision ) @@ -12,7 +12,7 @@ * in a userland package. Please be so kind as to leave them. */

-require './examine_diff.inc'; +require __DIR__ . '/examine_diff.inc'; date_default_timezone_set('America/New_York');

Index: ext/date/tests/DateTime_diff_add_sub-spring-type3-type3.phpt =================================================================== --- ext/date/tests/DateTime_diff_add_sub-spring-type3-type3.phpt (revision
308238) +++ ext/date/tests/DateTime_diff_add_sub-spring-type3-type3.phpt (revision ) @@ -12,7 +12,7 @@ * in a userland package. Please be so kind as to leave them. */

-require './examine_diff.inc'; +require __DIR__ . '/examine_diff.inc'; date_default_timezone_set('America/New_York');

Index: ext/date/tests/DateTime_diff_add_sub-massive.phpt =================================================================== --- ext/date/tests/DateTime_diff_add_sub-massive.phpt (revision 308238) +++ ext/date/tests/DateTime_diff_add_sub-massive.phpt (revision ) @@ -10,7 +10,7 @@ * in a userland package. Please be so kind as to leave them. */

-require './examine_diff.inc'; +require __DIR__ . '/examine_diff.inc'; date_default_timezone_set('America/New_York');

Index: ext/date/tests/DateTime_diff_add_sub-fall-type3-type3.phpt =================================================================== --- ext/date/tests/DateTime_diff_add_sub-fall-type3-type3.phpt (revision 308238) +++ ext/date/tests/DateTime_diff_add_sub-fall-type3-type3.phpt (revision ) @@ -12,7 +12,7 @@ * in a userland package. Please be so kind as to leave them. */

-require './examine_diff.inc'; +require __DIR__ . '/examine_diff.inc'; date_default_timezone_set('America/New_York');

Index: ext/date/tests/DateTime_diff_add_sub-spring-type2-type2.phpt =================================================================== --- ext/date/tests/DateTime_diff_add_sub-spring-type2-type2.phpt (revision
308238) +++ ext/date/tests/DateTime_diff_add_sub-spring-type2-type2.phpt (revision ) @@ -12,7 +12,7 @@ * in a userland package. Please be so kind as to leave them. */

-require './examine_diff.inc'; +require __DIR__ . '/examine_diff.inc'; date_default_timezone_set('America/New_York');

Index: ext/date/tests/DateTime_diff_add_sub-fall-type2-type3.phpt =================================================================== --- ext/date/tests/DateTime_diff_add_sub-fall-type2-type3.phpt (revision 308238) +++ ext/date/tests/DateTime_diff_add_sub-fall-type2-type3.phpt (revision ) @@ -12,7 +12,7 @@ * in a userland package. Please be so kind as to leave them. */

-require './examine_diff.inc'; +require __DIR__ . '/examine_diff.inc'; date_default_timezone_set('America/New_York');

Index: ext/date/tests/DateTime_diff_add_sub-spring-type2-type3.phpt =================================================================== --- ext/date/tests/DateTime_diff_add_sub-spring-type2-type3.phpt (revision
308238) +++ ext/date/tests/DateTime_diff_add_sub-spring-type2-type3.phpt (revision ) @@ -12,7 +12,7 @@ * in a userland package. Please be so kind as to leave them. */

-require './examine_diff.inc'; +require __DIR__ . '/examine_diff.inc'; date_default_timezone_set('America/New_York');

Index: ext/date/tests/DateTime_diff_add_sub-dates.phpt =================================================================== --- ext/date/tests/DateTime_diff_add_sub-dates.phpt (revision 308238) +++ ext/date/tests/DateTime_diff_add_sub-dates.phpt (revision ) @@ -10,7 +10,7 @@ * in a userland package. Please be so kind as to leave them. */

-require './examine_diff.inc'; +require __DIR__ . '/examine_diff.inc'; date_default_timezone_set('America/New_York');

Index: ext/date/tests/DateTime_diff_add_sub-february.phpt =================================================================== --- ext/date/tests/DateTime_diff_add_sub-february.phpt (revision 308238) +++ ext/date/tests/DateTime_diff_add_sub-february.phpt (revision ) @@ -10,7 +10,7 @@ * in a userland package. Please be so kind as to leave them. */

-require './examine_diff.inc'; +require __DIR__ . '/examine_diff.inc'; date_default_timezone_set('America/New_York');

Index: ext/date/tests/DateTime_diff_add_sub-fall-type2-type2.phpt =================================================================== --- ext/date/tests/DateTime_diff_add_sub-fall-type2-type2.phpt (revision 308238) +++ ext/date/tests/DateTime_diff_add_sub-fall-type2-type2.phpt (revision ) @@ -12,7 +12,7 @@ * in a userland package. Please be so kind as to leave them. */

-require './examine_diff.inc'; +require __DIR__ . '/examine_diff.inc'; date_default_timezone_set('America/New_York');

Index: ext/date/tests/DateTime_diff_add_sub-absolute.phpt =================================================================== --- ext/date/tests/DateTime_diff_add_sub-absolute.phpt (revision 308238) +++ ext/date/tests/DateTime_diff_add_sub-absolute.phpt (revision ) @@ -10,7 +10,7 @@ * in a userland package. Please be so kind as to leave them. */

-require './examine_diff.inc'; +require __DIR__ . '/examine_diff.inc'; date_default_timezone_set('America/New_York');

Index: ext/date/lib/parse_date.c =================================================================== --- ext/date/lib/parse_date.c (revision 310981) +++ ext/date/lib/parse_date.c (working copy) @@ -806,12 +806,10 @@ } #endif /* If we have a TimeZone identifier to start with, use it */ - if (strstr(tz_abbr, "/") || strcmp(tz_abbr, "UTC") == 0) { - if ((res = timelib_parse_tzfile(tz_abbr, tzdb)) != NULL) { - t->tz_info = res; - t->zone_type = TIMELIB_ZONETYPE_ID; - found++; - } + if ((res = timelib_parse_tzfile(tz_abbr, tzdb)) != NULL) { + t->tz_info = res; + t->zone_type = TIMELIB_ZONETYPE_ID; + found++; } if (found && t->zone_type != TIMELIB_ZONETYPE_ID) { timelib_time_tz_abbr_update(t, tz_abbr); Index: ext/date/lib/parse_date.re =================================================================== --- ext/date/lib/parse_date.re (revision 310981) +++ ext/date/lib/parse_date.re (working copy) @@ -804,13 +804,11 @@ } #endif /* If we have a TimeZone identifier to start with, use it */ - if (strstr(tz_abbr, "/") || strcmp(tz_abbr, "UTC") == 0) { - if ((res = timelib_parse_tzfile(tz_abbr, tzdb)) != NULL) { - t->tz_info = res; - t->zone_type = TIMELIB_ZONETYPE_ID; - found++; - } - } + if ((res = timelib_parse_tzfile(tz_abbr, tzdb)) != NULL) { + t->tz_info = res; + t->zone_type = TIMELIB_ZONETYPE_ID; + found++; + } if (found && t->zone_type != TIMELIB_ZONETYPE_ID) { timelib_time_tz_abbr_update(t, tz_abbr); }

-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php