atom feed3 messages in org.kernel.vger.linux-kernelRe: [PATCH] : Add dev-id and inode nu...
FromSent OnAttachments
Manish KatiyarMar 30, 2009 7:40 pm.patch
Andrew MortonApr 1, 2009 2:50 pm 
Manish KatiyarApr 3, 2009 3:34 am 
Subject:Re: [PATCH] : Add dev-id and inode number for debugging in init_special_inode in fs/inode.c
From:Manish Katiyar (mkat@gmail.com)
Date:Mar 30, 2009 7:40:37 pm
List:org.kernel.vger.linux-kernel
Attachments:

On Tue, Mar 31, 2009 at 5:03 AM, Andrew Morton <ak@linux-foundation.org> wrote:

On Mon, 23 Mar 2009 08:46:12 +0530 Manish Katiyar <mkat@gmail.com> wrote:

Hi Andrew,

Below patch adds device-id and inode number for better debugging.

Signed-off-by: Manish Katiyar <mkat@gmail.com>

---  fs/inode.c |    5 +++--  1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/inode.c b/fs/inode.c index 913ab2d..f75e9a4 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -1540,7 +1540,8 @@ void init_special_inode(struct inode *inode, umode_t mode, dev_t rdev)       else if (S_ISSOCK(mode))               inode->i_fop = &bad_sock_fops;       else -             printk(KERN_DEBUG "init_special_inode: bogus i_mode (%o)\n", -                    mode); +             printk(KERN_DEBUG "init_special_inode: bogus i_mode (%o) for" +                               " inode %s:%lu\n", mode, inode->i_sb->s_id, +                               inode->i_ino);  }  EXPORT_SYMBOL(init_special_inode);

I don't think this is really a trivial patch.  Please cc linux-kernel unless the patch is really really trivail.

The changelog falied to give any reason for making this change.  It should have done so!  I cannot work out the rationale from looking at the code change.

Hi Andrew, [resending it with updated changelog and ccing linux-kernel]

Below patch adds device-id and inode number for better debugging. This was suggested by Andreas in one of the threads http://article.gmane.org/gmane.comp.file-systems.ext4/12062 .

Signed-off-by: Manish Katiyar <mkat@gmail.com>

--- fs/inode.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/inode.c b/fs/inode.c index 913ab2d..f75e9a4 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -1540,7 +1540,8 @@ void init_special_inode(struct inode *inode, umode_t mode, dev_t rdev) else if (S_ISSOCK(mode)) inode->i_fop = &bad_sock_fops; else - printk(KERN_DEBUG "init_special_inode: bogus i_mode (%o)\n", - mode); + printk(KERN_DEBUG "init_special_inode: bogus i_mode (%o) for" + " inode %s:%lu\n", mode, inode->i_sb->s_id, + inode->i_ino); } EXPORT_SYMBOL(init_special_inode);

-- 1.5.4.3

PS: I have also attached the patch, in case it gets word wrapped.

Thanks - Manish

From 25d2ddc0336f1f828532475662e114bbd23f478a Mon Sep 17 00:00:00 2001 From: Manish Katiyar <mkat@gmail.com> Date: Mon, 23 Mar 2009 08:08:05 +0530 Subject: [PATCH] Add dev-id and inode number for debugging in init_special_inode

Signed-off-by: Manish Katiyar <mkat@gmail.com>

--- fs/inode.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/inode.c b/fs/inode.c index 913ab2d..f75e9a4 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -1540,7 +1540,8 @@ void init_special_inode(struct inode *inode, umode_t mode,
dev_t rdev) else if (S_ISSOCK(mode)) inode->i_fop = &bad_sock_fops; else - printk(KERN_DEBUG "init_special_inode: bogus i_mode (%o)\n", - mode); + printk(KERN_DEBUG "init_special_inode: bogus i_mode (%o) for" + " inode %s:%lu\n", mode, inode->i_sb->s_id, + inode->i_ino); } EXPORT_SYMBOL(init_special_inode);

-- 1.5.4.3