atom feed10 messages in org.apache.jackrabbit.oak-commitsRe: svn commit: r1309458 - /jackrabbi...
FromSent OnAttachments
ste...@apache.orgApr 4, 2012 8:36 am 
Jukka ZittingApr 4, 2012 11:59 pm 
Stefan GuggisbergApr 5, 2012 12:43 am 
Michael DürigApr 5, 2012 1:30 am 
Jukka ZittingApr 5, 2012 1:37 am 
Thomas MuellerApr 5, 2012 1:48 am 
Jukka ZittingApr 5, 2012 1:51 am 
Thomas MuellerApr 5, 2012 2:51 am 
Jukka ZittingApr 5, 2012 2:59 am 
Thomas MuellerApr 5, 2012 7:03 am 
Subject:Re: svn commit: r1309458 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/KernelNodeState.java
From:Thomas Mueller (muel@adobe.com)
Date:Apr 5, 2012 1:48:25 am
List:org.apache.jackrabbit.oak-commits

Hi,

That's what I was wondering, is a nodeExists() call followed by getNodes() better than a getNodes() call by itself? Especially if we assume potential network overhead for both calls...

That pattern pops up all over again. We should probably not use exceptions for signalling missing values but use null instead and use exceptions for exceptional cases.

I agree. What about

(a) getNodes() can return null, like java.util.Map.get(), or (b) getNodesOrNull() is added, and getNodes would still throw an exception.

I think the pattern "if nodeExists then getNodes" should be avoided also because the node might have been deleted just after calling nodeExists, depending on the underlying storage.

Regards, Thomas