216 messages in org.apache.wicket.usersRe: Free wicket from component hierar...| From | Sent On | Attachments |
|---|---|---|
| 17 earlier messages | ||
| Martin Grigorov | Nov 5, 2010 1:36 am | |
| Martin Makundi | Nov 5, 2010 1:37 am | |
| Martin Makundi | Nov 5, 2010 1:38 am | |
| Martin Makundi | Nov 5, 2010 1:40 am | |
| Leszek Gawron | Nov 5, 2010 5:36 am | |
| James Carman | Nov 5, 2010 5:39 am | |
| Martin Makundi | Nov 5, 2010 5:47 am | |
| Igor Vaynberg | Nov 5, 2010 9:55 am | |
| Jeremy Thomerson | Nov 5, 2010 10:00 am | |
| Martin Makundi | Nov 5, 2010 10:23 am | |
| Igor Vaynberg | Nov 5, 2010 11:19 am | |
| Martin Makundi | Nov 5, 2010 11:39 am | |
| Eelco Hillenius | Nov 5, 2010 11:49 am | |
| Eelco Hillenius | Nov 5, 2010 11:56 am | |
| Martin Makundi | Nov 5, 2010 11:58 am | |
| Martin Makundi | Nov 5, 2010 12:00 pm | |
| Eelco Hillenius | Nov 5, 2010 12:15 pm | |
| Igor Vaynberg | Nov 5, 2010 12:55 pm | |
| Brian Topping | Nov 5, 2010 12:56 pm | |
| Martin Makundi | Nov 5, 2010 1:06 pm | |
| Martin Makundi | Nov 5, 2010 1:14 pm | |
| Igor Vaynberg | Nov 5, 2010 1:21 pm | |
| Brian Topping | Nov 5, 2010 1:32 pm | |
| Martin Makundi | Nov 5, 2010 10:05 pm | |
| Martin Makundi | Nov 5, 2010 10:07 pm | |
| Jeremy Thomerson | Nov 5, 2010 10:48 pm | |
| Martin Makundi | Nov 5, 2010 11:31 pm | |
| Igor Vaynberg | Nov 5, 2010 11:53 pm | |
| Martin Makundi | Nov 5, 2010 11:57 pm | |
| James Carman | Nov 6, 2010 5:12 am | |
| Martin Makundi | Nov 6, 2010 5:20 am | |
| Jeremy Thomerson | Nov 6, 2010 6:22 am | |
| Martin Makundi | Nov 6, 2010 6:43 am | |
| samket | Nov 6, 2010 6:54 am | |
| Igor Vaynberg | Nov 6, 2010 4:44 pm | |
| Sebastian | Nov 8, 2010 8:17 am | |
| Vitaly Tsaplin | Nov 8, 2010 8:23 am | |
| Igor Vaynberg | Nov 8, 2010 8:27 am | |
| Martin Makundi | Nov 8, 2010 8:29 am | |
| Igor Vaynberg | Nov 8, 2010 8:35 am | |
| Vitaly Tsaplin | Nov 8, 2010 8:35 am | |
| Martin Makundi | Nov 8, 2010 8:42 am | |
| Sebastian | Nov 8, 2010 8:51 am | |
| Martin Makundi | Nov 8, 2010 8:58 am | |
| Igor Vaynberg | Nov 8, 2010 8:58 am | |
| Igor Vaynberg | Nov 8, 2010 9:03 am | |
| Sebastian | Nov 8, 2010 9:07 am | |
| Martin Makundi | Nov 8, 2010 9:13 am | |
| Omid Milani | Nov 8, 2010 9:31 am | |
| Igor Vaynberg | Nov 8, 2010 9:32 am | |
| Rodolfo Hansen | Nov 8, 2010 10:01 am | |
| Eelco Hillenius | Nov 8, 2010 10:22 pm | |
| Martin Makundi | Nov 8, 2010 10:39 pm | |
| Martin Makundi | Nov 8, 2010 10:40 pm | |
| Carl-Eric Menzel | Nov 9, 2010 12:15 am | |
| Martin Makundi | Nov 9, 2010 12:19 am | |
| Martin Makundi | Nov 9, 2010 12:23 am | |
| Carl-Eric Menzel | Nov 9, 2010 12:41 am | |
| Carl-Eric Menzel | Nov 9, 2010 12:44 am | |
| Martin Makundi | Nov 9, 2010 1:01 am | |
| Carl-Eric Menzel | Nov 9, 2010 4:12 am | |
| Martin Makundi | Nov 9, 2010 4:21 am | |
| Vitaly Tsaplin | Nov 9, 2010 4:29 am | |
| Martin Makundi | Nov 9, 2010 4:34 am | |
| Matthias Keller | Nov 9, 2010 4:46 am | |
| manuelbarzi | Nov 9, 2010 4:49 am | |
| James Carman | Nov 9, 2010 4:49 am | |
| Martin Makundi | Nov 9, 2010 4:54 am | |
| James Carman | Nov 9, 2010 4:57 am | |
| Martin Makundi | Nov 9, 2010 4:58 am | |
| manuelbarzi | Nov 9, 2010 5:26 am | |
| Martin Makundi | Nov 9, 2010 5:48 am | |
| Frank Silbermann | Nov 9, 2010 6:46 am | |
| Martin Grigorov | Nov 9, 2010 6:58 am | |
| Carl-Eric Menzel | Nov 9, 2010 7:02 am | |
| James Carman | Nov 9, 2010 7:05 am | |
| Carl-Eric Menzel | Nov 9, 2010 7:11 am | |
| Carl-Eric Menzel | Nov 9, 2010 7:14 am | |
| Frank Silbermann | Nov 9, 2010 7:19 am | |
| Martin Makundi | Nov 9, 2010 7:20 am | |
| Martin Makundi | Nov 9, 2010 7:22 am | |
| James Carman | Nov 9, 2010 7:26 am | |
| Frank Silbermann | Nov 9, 2010 7:28 am | |
| Martin Makundi | Nov 9, 2010 7:32 am | |
| Wilhelmsen Tor Iver | Nov 9, 2010 7:32 am | |
| Martin Makundi | Nov 9, 2010 7:33 am | |
| Carl-Eric Menzel | Nov 9, 2010 7:36 am | |
| John Owen | Nov 9, 2010 7:36 am | |
| James Carman | Nov 9, 2010 7:38 am | |
| Martin Makundi | Nov 9, 2010 7:45 am | |
| Frank Silbermann | Nov 9, 2010 7:48 am | |
| James Carman | Nov 9, 2010 7:51 am | |
| Martin Makundi | Nov 9, 2010 7:57 am | |
| James Carman | Nov 9, 2010 8:00 am | |
| Martin Makundi | Nov 9, 2010 8:04 am | |
| Carl-Eric Menzel | Nov 9, 2010 8:05 am | |
| Martin Makundi | Nov 9, 2010 8:06 am | |
| Martin Makundi | Nov 9, 2010 8:07 am | |
| Carl-Eric Menzel | Nov 9, 2010 8:10 am | |
| Sebastian | Nov 9, 2010 8:18 am | |
| 99 later messages | ||
| Subject: | Re: Free wicket from component hierarchy hell | |
|---|---|---|
| From: | Igor Vaynberg (igor...@gmail.com) | |
| Date: | Nov 8, 2010 9:32:13 am | |
| List: | org.apache.wicket.users | |
On Mon, Nov 8, 2010 at 9:07 AM, Sebastian <nosp...@gmx.net> wrote:
...and that makes the queue method a candidate to replace the add method without breaking anything.
not necessarily. while add() adds right away, queue holds componets in a buffer until after the oninitialize() cascade. so calling getparent() or walking the hieararchy cannot be done until after oninitialize() has been called on the parent container. this gives you no way to traverse and tweak the child hiearachy.
i might move the code so it creates the hierarchy just before the parent's oninitialize(), post seemed safer at first glance.
-igor
Regards,
Seb
On 08.11.2010 18:03, Igor Vaynberg wrote:
On Mon, Nov 8, 2010 at 8:58 AM, Martin Makundi <mart...@koodaripalvelut.com> wrote:
as I understand the readme the queue method basically has only a slightly different behavior compared to the add method in the way that it either adds a component as a direct child to the parent or as a sub-child as defined in the markup. So the markup is only used to determine the child's location below a given (code controlled) parent. This means if you replace the current add method with the behavior of the queue method, existing code will still work and we would not have two separate ways to add components. That sounds like a good solution.
@Martin: please start arguing with the given arguments and stop moaning. Thanks.
I would argue that it is not completely safe to _replace_ add method with queue method. As Igor pointed out before, we might want to define security boundaries: componentA must be inside componentB. Such code should be implemented either traditionally or otherwise the new way of adding components via queue must implement a security feature that allows restricting child components inside a certain parent component in a fluid but robust manner.
thats exactly what it does, as my readme file explains in the git branch...
-igor
Plain queue implementation, however, is a very good starting point to begin studying various ways of imposing security boundaries.
** Martin
On 08.11.2010 17:28, Igor Vaynberg wrote:
it is not about fixing something that isnt broken, its about making it easier. anyways, i just updated the readme in my experimental branch that explains the solution a bit more: https://github.com/ivaynberg/wicket/tree/component-queuing
-igor
On Mon, Nov 8, 2010 at 8:23 AM, Vitaly Tsaplin<vita...@gmail.com> wrote:
I'm sorry to say, but the whole discussion makes little sense to me and these attempts to fix something that is not broken actually scares me a bit.
+1