21 messages in com.xensource.lists.xen-ia64-develRe: [Xen-ia64-devel] [PATCH][3/3] Ste...
FromSent OnAttachments
Atsushi SAKAI07 Mar 2007 02:03.patch
Alex Williamson07 Mar 2007 15:59 
Atsushi SAKAI08 Mar 2007 03:51 
Alex Williamson08 Mar 2007 09:41 
Atsushi SAKAI08 Mar 2007 23:58.patch
Alex Williamson12 Mar 2007 11:43 
Aron Griffis05 May 2008 20:33 
Isaku Yamahata06 May 2008 20:45 
Atsushi SAKAI08 May 2008 04:02 
Isaku Yamahata08 May 2008 04:48 
Atsushi SAKAI08 May 2008 23:48 
Isaku Yamahata09 May 2008 00:02 
Atsushi SAKAI09 May 2008 00:30 
Isaku Yamahata11 May 2008 20:39 
Atsushi SAKAI13 May 2008 04:24 
Isaku Yamahata13 May 2008 19:07 
Atsushi SAKAI14 May 2008 02:23 
Isaku Yamahata14 May 2008 23:55 
Atsushi SAKAI15 May 2008 02:01 
Isaku Yamahata15 May 2008 02:10 
Atsushi SAKAI15 May 2008 03:46 
Subject:Re: [Xen-ia64-devel] [PATCH][3/3] Steal time accounting forPVdomain/IA64 TAKE2
From:Atsushi SAKAI (sak@jp.fujitsu.com)
Date:03/08/2007 03:51:39 AM
List:com.xensource.lists.xen-ia64-devel

Hi, Alex

Thank you for various comments. It helps many I will post a patch tomorrow, now testing.

Anyway I reply it in inline.

Why do we have to do these one at a time, instead of in bulk. Seems very inefficient. Also, please explain the local_irq_enable/disable at the end of each.

I re-check and confirmed that only do_timer needs multiple call. But this do_timer loop is not needed for later 2.6.19 since do_timer spec is changed from register value to tick counts.

For local_irq_enable/disable Issue, I saw 2.6.20 kernel and found timer_interrupt has local_irq_enable/disable. But this issue is effective for > 1024CPU case, So I will omit it since current CPU# is 64.

Reference. http://www.gelato.unsw.edu.au/archives/linux-ia64/0610/19314.html

Shouldn't this be in an #ifdef CONFIG_XEN? HYPERVISOR_vcpu_op isn't going to compile otherwise. It should probably have a stub for the non-CONFIG_XEN case so you don't have to #ifdef out the caller.

I forgot to add #ifdef CONFIG_XEN. I will fix it.

Is there any reason to filter out the other defined vcpu_ops? Maybe we should add support for them now.

I filter vcpu_op, just because I check only one hypercall. I consider it as my backlog.