6 messages in com.xensource.lists.xen-develRe: [Xen-devel] anybody using pdb?
FromSent OnAttachments
Christian Limpach10 Mar 2004 16:09 
Keir Fraser11 Mar 2004 00:28 
Christian Limpach11 Mar 2004 09:21 
Keir Fraser11 Mar 2004 23:50 
Keir Fraser12 Mar 2004 03:52 
Christian Limpach12 Mar 2004 07:10 
Subject:Re: [Xen-devel] anybody using pdb?
From:Keir Fraser (Keir@cl.cam.ac.uk)
Date:03/11/2004 11:50:29 PM
List:com.xensource.lists.xen-devel

I've fixed this a better way, by enabling interrupts before calling the pdb handler. Let me know if it still doesn't work.

No it doesn't work, at least not for the "jump to the debugger by pressing D" case. Maybe because you only enabled interrupts during traps but not during interrupts? AFAICT there's also some locking/flag setting which might prevent further interrupts while the handler is still running (if I'm looking at the right code, do_IRQ in xen/arch/i386/irq.c).

I considered enabling interrupts at first but I couldn't exclude re-entrance issues. Also I think that it's not the right thing to do in this case: if you're using the debugger on Xen, you don't want interrupts enabled. I think you'd actually want them explicitly disabled (as opposed to the previous/current implicit disabling).

Hmmmm... maybe you're right. :-)

Certainly I've changed my mind about yesterday's fix. I'll back it out and do something along the lines of what you posted in the first place.

-- Keir