2 messages in com.xensource.lists.xen-ia64-develRE: [Xen-ia64-devel] [PATCH] fixed as...
FromSent OnAttachments
Magenheimer, Dan (HP Labs Fort Collins)15 Dec 2005 11:57 
Isaku Yamahata15 Dec 2005 18:58 
Subject:RE: [Xen-ia64-devel] [PATCH] fixed asm-offset.h asm-xsi-offset.hgeneration
From:Magenheimer, Dan (HP Labs Fort Collins) (dan.@hp.com)
Date:12/15/2005 11:57:11 AM
List:com.xensource.lists.xen-ia64-devel

The sed line that is used is exactly the same as in linux (see sed-y in linux-2.6.14/Kbuild) so I don't think that the Xen team will change the Makefile. Does vanilla binutils work to build Linux?

Thanks, Dan

-----Original Message----- From: xen-@lists.xensource.com [mailto:xen-@lists.xensource.com] On Behalf Of Isaku Yamahata Sent: Wednesday, December 14, 2005 1:00 AM To: xen-@lists.xensource.com Subject: [Xen-ia64-devel] [PATCH] fixed asm-offset.h asm-xsi-offset.hgeneration

Hi

Vanilla binutils refuse to assemble -imm0 - -imm1 as a syntax error, so that linux-2.6-sparse/arch/ia64/xen/xenivt.S can't be compiled. This patch adds parens to fix it. Although it seems that some distributions modify their binutils to accept such syntax(at least redhat, debian), I think xen should be able to be compiled with vanilla binutils.

Signed-off-by: Isaku Yamahata <yama@valinux.co.jp>

-- diff -r 1a6e70e434ad -r 7e68cdd9a405 xen/Makefile --- a/xen/Makefile Thu Dec 1 18:19:35 2005 +0900 +++ b/xen/Makefile Thu Dec 1 18:19:47 2005 +0900 @@ -116,7 +116,7 @@ echo "#ifndef __ASM_OFFSETS_H__"; \ echo "#define __ASM_OFFSETS_H__"; \ echo ""; \ - sed -ne "/^->/{s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; s:->::; p;}"; \ + sed -ne "/^->/{s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 (\2) /* \3 */:; s:->::; p;}"; \ echo ""; \ echo "#endif") <$< >$@

diff -r 1a6e70e434ad -r 7e68cdd9a405 xen/arch/ia64/Makefile --- a/xen/arch/ia64/Makefile Thu Dec 1 18:19:35 2005 +0900 +++ b/xen/arch/ia64/Makefile Thu Dec 1 18:19:47 2005 +0900 @@ -58,7 +58,7 @@ echo "#ifndef __ASM_XSI_OFFSETS_H__"; \ echo "#define __ASM_XSI_OFFSETS_H__"; \ echo ""; \ - sed -ne "/^->/{s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; s:->::; p;}"; \ + sed -ne "/^->/{s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 (\2) /* \3 */:; s:->::; p;}"; \ echo ""; \ echo "#endif") <$< >$@