7 messages in net.sourceforge.lists.courier-usersRe: [courier-users] Re: cleanup couri...
FromSent OnAttachments
Johannes ErdfeltDec 5, 2003 3:35 pm 
Sam VarshavchikDec 5, 2003 4:13 pm 
Johannes ErdfeltDec 5, 2003 4:41 pm 
Sam VarshavchikDec 5, 2003 4:54 pm 
Johannes ErdfeltDec 5, 2003 5:14 pm 
Sam VarshavchikDec 5, 2003 5:33 pm 
Johannes ErdfeltDec 5, 2003 5:49 pm 
Actions with this message:
Paste this link in email or IM:
Paste this link in email or IM:
Atom feed for this thread
Paste this URL into your reader:
Subject:Re: [courier-users] Re: cleanup courier.spec fileActions...
From:Johannes Erdfelt (joha@erdfelt.com)
Date:Dec 5, 2003 4:41:40 pm
List:net.sourceforge.lists.courier-users

On Fri, Dec 05, 2003, Sam Varshavchik <mrs@courier-mta.com> wrote:

Johannes Erdfelt writes:

I only use a few packages from the Courier MTA, but the spec file always installed some files for MySQL, PostgreSQL and Fax support.

This is because the configuration files are installed via sysconftool from %post, only.

I haven't looked at your changes in detail, but I suspect that fresh install on a pristine systems will be broken by your patch, because after installing one of those subpackages sysconftool will not run to actually install the configuration files. You could've easily missed that if you were working on a system with an existing Courier install, where the configuration files are already there.

The fact that some configuration files are installed by the main package, instead of a more appropriate subpackage, is not the end of the world.

Perhaps. I did all of my testing from an upgrade of a previous install.

I looked briefly at what was happening and it looked correct still, so I tested and didn't have any problems.

I'll do some more testing to make sure everything is still working as designed.

Also, the patch cleans up how filelist1 is finally processed to produce filelist for the main package. Before this patch, each package would grab the files from filelist1 and place the lines into their own filelist and then the reverse was done to filelist1 to produce filelist.

The patch changes it to use sort and uniq to automatically produce filelist from filelist1 and the per package filelist.* files by using only the unique lines from filelist1.

Your implementation looks wrong. Looks you're putting EVERYTHING into filelist, instead of just the main package's files.

Look at it again:

cat filelist.* filelist1 | sort | uniq -u > filelist

All of the lines are in filelist1, but only some are in filelist.*

What happens is that the lines in filelist.* end up being duplicated. The call to "sort | uniq -u" results in only the unique lines being printed (ie the lines *not* in filelist.*)

This way, the contents of filelist.* and filelist merged together are exactly what's in filelist1. (well, until a couple of lines below this in the spec file)

JE