Re: [Xen-ia64-devel] [PATCH]fix initialization order of buddy allocator - Isaku Yamahata - com.xensource.lists.xen-ia64-devel

6 messages in com.xensource.lists.xen-ia64-develRe: [Xen-ia64-devel] [PATCH]fix initi...

From	Sent On	Attachments
Daisuke Nishimura	28 May 2007 03:48	.patch
Isaku Yamahata	28 May 2007 04:27
Daisuke Nishimura	28 May 2007 22:58	.patch
Daisuke Nishimura	29 May 2007 01:54	.patch
Alex Williamson	29 May 2007 08:58
Alex Williamson	31 May 2007 14:18

Subject:	Re: [Xen-ia64-devel] [PATCH]fix initialization order of buddy allocator
From:	Isaku Yamahata (yama...@valinux.co.jp)
Date:	05/28/2007 04:27:54 AM
List:	com.xensource.lists.xen-ia64-devel

On Mon, May 28, 2007 at 07:48:51PM +0900, Daisuke Nishimura wrote:

Machines with multi NUMA nodes may panic on bootup. Attached patch(for C/S15145), in which I modified the initialization order of buddy allocator, fixes this problem. I tested booting dom0/domVTi and kernel-make on guests. Any comments and feedbacks would be appreciated.

Good catch!

2. The xenheap area (from xen_pstart to xenheap_phys_end) must exist in node0 from its design? (As far as I know, if xenheap is not in node0, the initialization process of xenheap recursively needs xenheap memory)

It seems so because of _heap0 and avail0. it would be easily worked around by alllocating _heap[n] and avail[n] by boot allocator.

BTW your signed-off-by is missing. -- yamahata