On Fri, Jul 3, 2009 at 1:20 AM, Boris Burtin<bbur...@zimbra.com> wrote:
It's not immediately obvious whether SieveFactory is thread-safe. From looking
at the code, it looks like I can access a single instance of SieveFactory
concurrently. Can someone please confirm? It would be nice to have this
specified in the javadocs.
it's more concurrent than it was ;-)
i observed concurrency issues with the 0.2 code base which seem to
have gone now but AFAIK no full analysis has been performed. i'll try
to find time to take a look and this and update the javadocs
appropriately.
One thing I noticed is that CommandManagerImpl, ComparatorManagerImpl, and
TestManagerImpl all have a classNameMap instance variable. Seems like everything
is safe, as long as I don't try to modify the maps after the server has started.
Wouldn't be a bad idea to use ConcurrentHashMap in ConfigurationManager instead
of HashMap to handle this edge case.
+1
- robert
2 messages in org.apache.james.server-devRe: jSieve: docs for SieveFactory thr...