s/phsysical/physical/

s/rigth/right/

+#ifdef HAVE_XEN_PLATFORM_COMPAT_H +#include <xen/platform-compat.h> +#endif

What is this for? This patch series doesn't make this file.

+static unsigned long kernel_start_pa; + +void +xencomm_initialize(void) +{ + kernel_start_pa = KERNEL_START - ia64_tpa(KERNEL_START); +}

"kernel_start_pa" is an unhelpful name ... this variable doesn't contain the starting physical address (which is what the name sounds like). Perhaps "kernel_virtual_offset" is better?

+ if (vaddr > TASK_SIZE) { + /* kernel address */ + return __pa(vaddr); + }

Can this routine ever be given the address of a percpu variable? This will return the wrong value if someone does.

+#define is_kernel_addr(x) \ + ((PAGE_OFFSET <= (x) && \ + (x) < (PAGE_OFFSET + (1UL << IA64_MAX_PHYS_BITS))) || \ + (KERNEL_START <= (x) && \ + (x) < KERNEL_START + KERNEL_TR_PAGE_SIZE))

Misleading name. What does it consider a "kernel_addr"? Just region 7 (up to physical address limit) and the piece of region 5 that is mapped by itr[0]/dtr[0]. Preferebly pick a better name or add a comment here saying what this is testing for.

-Tony