6 messages in com.perforce.perforce-user[p4] Bugzilla 2.12 & P4DTI| From | Sent On | Attachments |
|---|---|---|
| Albrecht, Matt | 01 Aug 2001 08:30 |  .py |
| Bruce Edge | 01 Aug 2001 09:13 | |
| Gareth Rees | 02 Aug 2001 12:04 | |
| Gareth Rees | 02 Aug 2001 12:17 | |
| Albrecht, Matt | 03 Aug 2001 16:27 | |
| Nick Barnes | 06 Aug 2001 05:08 |
| Subject: | [p4] Bugzilla 2.12 & P4DTI |
|---|---|
| From: | Gareth Rees (gd...@ravenbrook.com) |
| Date: | 08/02/2001 12:04:53 PM |
| List: | com.perforce.perforce-user |
FYI, FTA.
At 10:30 -0500 2001-08-01, Albrecht, Matt wrote:
I had to make a mod to the P4DTI that made it look for new Bugzilla entries - without it, P4DTI would never see new entries and propagate them over to P4. Also, there's apparently a slight bug with the to-string transformation for inserting into MySQL, where a date (as opposed to a string) is passed into the routine.
Other than that, everything seems to work.
I've attached my changes to the standard distro of bugzilla.py.
-Matt Albrecht SQA Engineer Zilliant, Inc
-----Original Message----- From: Dave Gough [mailto:david at ace-comp.com] Sent: Tuesday, July 31, 2001 1:30 PM To: perforce-user at perforce.com Subject: [p4] Bugzilla 2.12 & P4DTI
Has anyone gotten Bugzilla 2.12 and P4DTI to play well with one another? P4DTI suggests 2.10, but I thought I'd check to see if the newest stable was any better and still functional.
--
Dave Gough System Administrator
Matt Albrecht had modified bugzilla.py from release 1.1.1. Here are the changes he made:
224,227c224,232 < if (type(value) != types.StringType): < # "Given '%s' when expecting a string." < raise error, catalog.msg(105, str(value)) < return "'" + self.db.escape_string(value) + "'"
---
# This is not safe! if (type(value) != types.StringType): return "'" + self.db.escape_string( str( value ) ) + "'" return "'" + self.db.escape_string( value ) + "'" # if (type(value) != types.StringType): # # "Given '%s' when expecting a string." # raise error, catalog.msg(105, str(value)) # raise error, catalog.msg(105, str(value) + ' (type '+str(type(value))+')') # return "'" + self.db.escape_string(value) + "'"
308d312 < 371d374 < 622d624 < 739a742,753
# MCA 15-Jun-2001: # Very first, we need to find all 'bug' entries which do not # have 'p4dti_bug' entries. Fortunately, MySQL provides us an # OUTER JOIN
just_new = self.fetch_rows_as_list_of_dictionaries( ("select bugs.* from bugs " " left join p4dti_bugs " # get all bugs " using (bug_id) " # based on bug_id " where p4dti_bugs.bug_id is NULL"), # where there is no P4 entry "bugs that P4 has not seen")
795c809 < bugs = changed + new_and_touched
---
bugs = just_new + changed + new_and_touched 1123a1138