Re: [Xen-devel] compile error of HVM pv drivers - Keir Fraser - com.xensource.lists.xen-devel

22 messages in com.xensource.lists.xen-develRe: [Xen-devel] compile error of HVM ...

From	Sent On	Attachments
Zhao, Yunfeng	30 Jul 2007 02:28
Keir Fraser	30 Jul 2007 02:51
Kieran Mansley	30 Jul 2007 02:58
Mats Petersson	30 Jul 2007 03:13
Zhao, Yunfeng	30 Jul 2007 05:43
Kieran Mansley	30 Jul 2007 06:41
Zhao, Yunfeng	30 Jul 2007 06:49
Kieran Mansley	30 Jul 2007 07:04
Zhao, Yunfeng	30 Jul 2007 07:14
Zhao, Yunfeng	30 Jul 2007 07:22
Kieran Mansley	30 Jul 2007 07:23
Zhao, Yunfeng	30 Jul 2007 07:32
Zhao, Yunfeng	30 Jul 2007 07:38
Keir Fraser	30 Jul 2007 07:42
Kieran Mansley	30 Jul 2007 07:46
Keir Fraser	30 Jul 2007 07:51
Kieran Mansley	30 Jul 2007 07:54
Zhao, Yunfeng	30 Jul 2007 08:02
Keir Fraser	30 Jul 2007 08:05
Zhao, Yunfeng	30 Jul 2007 08:38
Kieran Mansley	30 Jul 2007 08:42
Keir Fraser	30 Jul 2007 09:41

Subject:	Re: [Xen-devel] compile error of HVM pv drivers
From:	Keir Fraser (ke...@xensource.com)
Date:	07/30/2007 08:05:00 AM
List:	com.xensource.lists.xen-devel

I think you'll find that doesn't fix the problem. The () is there for a reason.

On 30/7/07 16:02, "Zhao, Yunfeng" <yunf...@intel.com> wrote:

The problem may be from the new changes in unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h

the following two lines: #define netif_tx_lock_bh(dev) (spin_lock_bh(&(dev)->xmit_lock)) #define netif_tx_unlock_bh(dev) (spin_unlock_bh(&(dev)->xmit_lock)) should be #define netif_tx_lock_bh(dev) (spin_lock_bh(&dev->xmit_lock)) #define netif_tx_unlock_bh(dev) (spin_unlock_bh(&dev->xmit_lock)) "()" is useless for dev.

Thanks Yunfeng

-----Original Message----- From: Keir Fraser [mailto:ke...@xensource.com] Sent: 2007年7月30日 22:52 To: Kieran Mansley; Zhao, Yunfeng Cc: xen-...@lists.xensource.com Subject: Re: [Xen-devel] compile error of HVM pv drivers

On 30/7/07 15:47, "Kieran Mansley" <kman...@solarflare.com> wrote:

In that case replacing the calls (there are two in that file) to netif_tx_lock_bh() with:

spin_lock_bh(&vif_state->np->netdev->xmit_lock);

And similarly the calls to netif_tx_unlock_bh() with spin_unlock_bh(), may solve your problem.

If this works for you I'll make a patch that uses the kernel version to decide which is appropriate.

Compat issues when building PV-on-HVM drivers are patched up out-of-band in the special unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h header file.

-- Keir