atom feed23 messages in org.apache.tomcat.devRe: AccessLogValve enhancement
FromSent OnAttachments
Mark ClaassenFeb 15, 2012 1:23 pm 
Mark ThomasFeb 15, 2012 1:32 pm 
Mark ClaassenFeb 15, 2012 1:55 pm 
Konstantin KolinkoFeb 15, 2012 2:06 pm 
Mark ClaassenFeb 16, 2012 7:16 am 
Mark ClaassenFeb 16, 2012 1:05 pm.zip
Konstantin KolinkoFeb 16, 2012 1:11 pm 
Mark ClaassenFeb 16, 2012 1:44 pm 
Filip Hanik - Dev ListsFeb 17, 2012 7:22 am 
Francis GaliegueFeb 17, 2012 7:54 am 
Filip Hanik - Dev ListsFeb 17, 2012 8:04 am 
Rainer JungFeb 17, 2012 8:13 am 
Christopher SchultzFeb 19, 2012 9:20 am 
Mark ThomasFeb 19, 2012 9:49 am 
Mark ClaassenFeb 19, 2012 6:53 pm 
Christopher SchultzFeb 21, 2012 8:37 am 
Mark ClaassenFeb 24, 2012 8:49 am 
Mark ClaassenMar 27, 2012 6:29 am 
Konstantin KolinkoMar 27, 2012 6:46 am 
Mark ClaassenMar 27, 2012 8:16 am 
Mark ClaassenMar 29, 2012 9:51 am 
Konstantin KolinkoMar 29, 2012 1:43 pm 
Mark ClaassenApr 11, 2012 11:09 am 
Subject:Re: AccessLogValve enhancement
From:Mark Thomas (mar@apache.org)
Date:Feb 15, 2012 1:32:23 pm
List:org.apache.tomcat.dev

On 15/02/2012 21:23, Mark Claassen wrote:

We would like to use the flexibility of the standard logging mechanism for the AccessLogValue. I could find no way to do this. Looking at the AccessLogValve code in Tomcat 7, it seems it would really would not be hard to add.

I added org.apache.juli.VerbatimFormatter some time ago with this in mind but never got around to implementing it.

There already is standard logger in the AccessLogValve class, which is where error in the logger itself get routed. private static final Log log = LogFactory.getLog(AccessLogValve.class);

This still makes a lot of sense, and should probably be kept separate.

+1

What I would propose is that a new attribute be added, called maybe "systemLoggerName". If this is set, then the logger by that name would be used instead of the current hard-coded file logger. (Errors would still go to the statically defined Logger.)

<aside> Woot! A bike shed to paint. :) </aside>

outputLoggerName?

I already tried this with the XML listed below and a slightly modified AccessLogValve and it seems to work perfectly. If this is something that would be considered a positive change, I would be happy to submit a patch and propose some documentation updates.

I assume that the "directory" and "prefix" attributes below are unnecessary.

I am not exactly sure how this all works, especially since this is more of an enhancement rather than a bug fix. I sure there are guidelines for when in a release cycle these types of changes are appropriate.

There is a very detailed 143 page process document for approving changes like this. Fortunately it may be summed up as "If you can convince a committer to make the change and no other committer vetos the change it will be in the next release.". As long as backwards compatibility is retained, I can't imagine why someone might complain (unless the patch is a mess).

I also be +1 to considering making this the sole way AccessLogValve logging may be output.

Mark