13 messages in com.xensource.lists.xen-develRe: [Xen-devel] [RFC][PATCH] Use ioem...
FromSent OnAttachments
Kevin Wolf10 Mar 2008 10:03.patch
Kevin Wolf13 Mar 2008 05:25.patch
Konrad Rzeszutek13 Mar 2008 07:20 
Kevin Wolf14 Mar 2008 02:37.patch
Konrad Rzeszutek17 Mar 2008 07:12 
Ian Jackson28 Mar 2008 08:22 
Kevin Wolf31 Mar 2008 02:09 
Ian Jackson31 Mar 2008 02:36 
Kevin Wolf31 Mar 2008 04:11 
Ian Jackson31 Mar 2008 06:22 
Keir Fraser31 Mar 2008 06:31 
Kevin Wolf31 Mar 2008 06:36 
Ian Jackson31 Mar 2008 06:37 
Subject:Re: [Xen-devel] [RFC][PATCH] Use ioemu block drivers through blktap
From:Ian Jackson (Ian.@eu.citrix.com)
Date:03/31/2008 02:36:36 AM
List:com.xensource.lists.xen-devel

Kevin Wolf writes ("Re: [Xen-devel] [RFC][PATCH] Use ioemu block drivers through
blktap"):

I needed a shutdown handler to properly close the blktap connection and delete the named pipes associated with the qemu-dm instance. When a domain is destroyed, qemu-dm receives a SIGHUP. However, with the default SIGHUP handler no atexit functions are called, so I had to add this handler which performs a clean exit.

Sadly in that case using a signal hanlder is no good, because qemu-dm might die for some other reason than SIGHUP, skipping the cleanup. (For example, it might have a bug and segfault, or the kernel's OOM killer might send it a SIGKILL, or ...)

If this cleanup is really necessary, then that will cause problems for future runs. If not then the cleanup isn't really necessary :-). Leftover named pipes, for example, aren't really a big problem and can just be garbage collected at some point (provided their names are sufficiently unique).

I haven't eyeballed all of the new qemu blktap arrangements in detail. What processes are there and why can't the process at the other end of the pipe do the cleanup ?

Ian.