Alan Runyan wrote:

I see why this would be the most common case, but:

CMFFormController is a high(ish) level page flow solution, it feels wrong for it to doom a transaction which may have other things going on. For example, you may want to write a validator and have two exit paths: a "success" page and a "failed" page, but you may still want some stuff written to the database in case of a failure. I don't think this is unreasonable or an unsupported use case in the current implementation.

We can't break that, nor should we. It's very easy to write code that doesn't do the "wrong" thing (that is - you write the "write" in the success path after the validator). If you have a write somewhere else, then either you meant to do that (in which case we shouldn't stomp on your code), or you have a serious, but easily discoverable bug (in which case we shouldn't try to hide that bug from you).

Also - if you wrote some temporary data before the validator and you do want the validator-failed use case to abort, calling transaction.abort/doom yourself is trivial (and explicit). I suspect in 99% of cases, there'd be no temporary data written before the validator. In fact, the validator tends to be the first thing in the chain after the page template in most cases.

Martin