atom feed16 messages in org.kernel.vger.kernel-janitors[PATCH 8/9] iwlegacy: use correct str...
FromSent OnAttachments
Julia LawallJul 29, 2014 8:16 am 
Julia LawallJul 29, 2014 8:16 am 
Julia LawallJul 29, 2014 8:16 am 
Julia LawallJul 29, 2014 8:16 am 
Julia LawallJul 29, 2014 8:16 am 
Julia LawallJul 29, 2014 8:16 am 
Julia LawallJul 29, 2014 8:16 am 
Julia LawallJul 29, 2014 8:16 am 
Julia LawallJul 29, 2014 8:16 am 
Julia LawallJul 29, 2014 8:16 am 
Brown, Aaron FJul 29, 2014 1:22 pm 
Alexandre CourbotJul 30, 2014 1:27 am 
Julia LawallJul 30, 2014 1:48 am 
David MillerJul 30, 2014 7:14 pm 
David MillerJul 30, 2014 7:14 pm 
Linus WalleijAug 8, 2014 6:26 am 
Subject:[PATCH 8/9] iwlegacy: use correct structure type name in sizeof
From:Julia Lawall (Juli@lip6.fr)
Date:Jul 29, 2014 8:16:50 am
List:org.kernel.vger.kernel-janitors

From: Julia Lawall <Juli@lip6.fr>

Correct typo in the name of the type given to sizeof. Because it is the size of a pointer that is wanted, the typo has no impact on compilation or execution.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The semantic patch used can be found in message 0 of this patch series.

diff --git a/drivers/net/wireless/iwlegacy/common.c
b/drivers/net/wireless/iwlegacy/common.c index 03de746..2c4fa49 100644 --- a/drivers/net/wireless/iwlegacy/common.c +++ b/drivers/net/wireless/iwlegacy/common.c @@ -2980,7 +2980,8 @@ il_tx_queue_alloc(struct il_priv *il, struct il_tx_queue
*txq, u32 id) /* Driver ilate data, only for Tx (not command) queues, * not shared with device. */ if (id != il->cmd_queue) { - txq->skbs = kcalloc(TFD_QUEUE_SIZE_MAX, sizeof(struct skb *), + txq->skbs = kcalloc(TFD_QUEUE_SIZE_MAX, + sizeof(struct sk_buff *), GFP_KERNEL); if (!txq->skbs) { IL_ERR("Fail to alloc skbs\n");