8 messages in ru.sysoev.nginxRe: cache purge| From | Sent On | Attachments |
|---|---|---|
| 冉兵 | Nov 16, 2009 7:36 pm | |
| Piotr Sikora | Nov 16, 2009 9:09 pm | |
| 冉兵 | Nov 16, 2009 10:15 pm | |
| Piotr Sikora | Nov 16, 2009 11:23 pm | |
| 冉兵 | Nov 16, 2009 11:33 pm | |
| Johan Bergström | Nov 16, 2009 11:52 pm | |
| Piotr Sikora | Nov 17, 2009 12:23 am | |
| 冉兵 | Nov 17, 2009 1:47 am |
| Subject: | Re: cache purge | |
|---|---|---|
| From: | Johan Bergström (joh...@bergstroem.nu) | |
| Date: | Nov 16, 2009 11:52:45 pm | |
| List: | ru.sysoev.nginx | |
Hey,
while you're patching - please update the example as well. We found (a while
ago, sorry for not letting you know) that since location matches "omits" args
from $1, we need to add it again. proper example should be:
location ~ /purge(/.*) {
allow 127.0.0.1;
deny all;
proxy_cache_purge tmpcache $1$is_args$args;
}
On 17 nov 2009, at 08.23, Piotr Sikora wrote:
One of my developers did the patch manually and she might have introduced some
bugs during the process.
I doubt that she introduced any, because patch for nginx-0.8.8 applies cleanly
(without any modifications) against latest nginx.
Anyway, this "bug" you were seeing appeared when original patch was applied
against nginx-0.8.11 or newer (long story short: r->cache->body_start was never
set and nginx tried to read 0 bytes). This is fixed now.
Would it be easier to make it a standalone module rather than a patch for users?
It was created as a patch, because we (Johan Bergstr?m from yo.se, who funded
this patch and me) hoped that it would be imported to nginx's base someday.
I'm waiting for your new patch to the latest nginx and I'll test it out and
report back.
Patch against nginx-0.8.26 is available at: http://labs.frickle.com/nginx_cache_purge/
In the future, please report when you find bugs ;)
Best regards, Piotr Sikora < piot...@frickle.com >