29 messages in net.java.dev.phoneme.advancedRe: Code review for new code submissi...| From | Sent On | Attachments |
|---|---|---|
| Hinkmond Wong | Apr 24, 2008 6:05 pm | |
| Danila Sinopalnikov | Apr 25, 2008 1:41 am | |
| Davy Preuveneers | Apr 25, 2008 2:45 am | |
| Danila Sinopalnikov | Apr 25, 2008 3:08 am | |
| Jiangli Zhou | Apr 25, 2008 9:55 am | |
| Davy Preuveneers | May 5, 2008 2:48 am |  .diff |
| Stephen Flores | May 8, 2008 7:41 pm | |
| Jiangli Zhou | May 12, 2008 11:44 am | |
| Davy Preuveneers | May 13, 2008 1:01 am | |
| Jiangli Zhou | May 13, 2008 9:25 am | |
| Davy Preuveneers | May 13, 2008 12:06 pm | .diff |
| Stephen Flores | May 13, 2008 6:48 pm | |
| phon...@mobileandembedded.org | May 23, 2008 6:16 pm | |
| Davy Preuveneers | May 24, 2008 1:14 am | .diff, .diff, .diff, 3 more |
| phon...@mobileandembedded.org | May 27, 2008 5:25 pm | |
| phon...@mobileandembedded.org | Jun 4, 2008 6:26 pm | |
| phon...@mobileandembedded.org | Jun 14, 2008 1:13 pm | |
| phon...@mobileandembedded.org | Jun 14, 2008 9:18 pm | |
| xyzzy (Dean) | Jun 15, 2008 1:42 am | |
| phon...@mobileandembedded.org | Jun 15, 2008 3:16 am | |
| xyzzy (Dean) | Jun 16, 2008 12:47 pm | |
| phon...@mobileandembedded.org | Jun 16, 2008 1:56 pm | |
| phon...@mobileandembedded.org | Jun 16, 2008 3:36 pm | |
| phon...@mobileandembedded.org | Jun 16, 2008 3:55 pm | |
| phon...@mobileandembedded.org | Jun 16, 2008 3:56 pm | |
| Hinkmond Wong | Jun 16, 2008 3:57 pm | |
| phon...@mobileandembedded.org | Jun 16, 2008 4:24 pm | |
| phon...@mobileandembedded.org | Jun 16, 2008 4:33 pm | |
| phon...@mobileandembedded.org | Aug 22, 2008 9:50 pm |
| Subject: | Re: Code review for new code submission from Davy Preuveneers (4/24/2008) | |
|---|---|---|
| From: | Jiangli Zhou (Jian...@Sun.COM) | |
| Date: | Apr 25, 2008 9:55:05 am | |
| List: | net.java.dev.phoneme.advanced | |
Hi Davy,
For the changes in MIDPLauncher.java and CdcMIDletSuiteLoader.java, using reflection to invoke the new CdcMIDletSuiteLoader.setProperties() is not really necessary. Since the CdcMIDletSuiteLoader class is only used for MIDP/CDC stack, it is safe to access sun.misc classes from there. I think you can add a new method (something like readSuiteProperties()) in sun.misc.MIDPConfig to read the the manifest attributes. That way you don't need to duplicate the while loop in two places. You can add another method in MIDPConfig (such as getSuiteProperties(), which returns the properties gathered from the manifest. You can call that method from CdcMIDletSuiteLoader to obtain the properties. With those, you don't need the new setProperties() method and the 'properties' filed in CdcMIDletSuiteLoader.
Regards,
Jiangli
Hinkmond Wong wrote:
This is a call for external code review of a new code submission from Davy Preuveneers (4/24/2008).
His changes include changes to MIDP, Personal Basis/Personal Profile, and CLDC:
* The Alert patch has been extended a bit with a new method to play custom sounds (path is harded coded though), but the current behavior is to still play the default system sounds. This should provide some audio feedback if JSR 135 is not there.
* The AwtPPC and AwtPPCStub patches convert some path definitions with POSIX2HOST and add new missing method (clearBackground). It also provides a dummy PPCRobotHelper and related classes and sources to get the Personal Profile compilation working.
* The CLDC and MIDP patches currently only add configuration support for WM2003 (to compile with eVC4).
Here are the code diffs (vs. rev. 11040 of the phoneME SVN repo):
https://phoneme.dev.java.net/nonav/issues/showattachment.cgi/10/Alert.rev11040.diff
https://phoneme.dev.java.net/nonav/issues/showattachment.cgi/11/AwtPPC.rev11040.diff
https://phoneme.dev.java.net/nonav/issues/showattachment.cgi/12/AwtPPCStubs.rev11040.diff
https://phoneme.dev.java.net/nonav/issues/showattachment.cgi/13/CLDC.rev11040.diff
https://phoneme.dev.java.net/nonav/issues/showattachment.cgi/14/MIDP.rev11040.diff
https://phoneme.dev.java.net/nonav/issues/showattachment.cgi/15/Suite.rev11040.diff
Davy, please feel free to add any additional comments to this thread in the forums.
Everyone else, please take a look at the above diffs and send in your comments and/or questions on how they look for committing to our repository.
This code review will be open until Fri. 5/23/2008.
Thanks,
Hinkmond