10 messages in com.xensource.lists.xen-develRe: [Xen-devel] Re: [Xense-devel][XSM...
FromSent OnAttachments
George S. Coker, II27 Sep 2007 09:43.diff
Stefan Berger27 Sep 2007 11:35 
Coker, George27 Sep 2007 12:34 
Stefan Berger27 Sep 2007 13:12 
George S. Coker, II27 Sep 2007 13:47 
Syunsuke HAYASHI28 Sep 2007 00:56 
Stefan Berger28 Sep 2007 07:21 
George S. Coker, II28 Sep 2007 08:05 
Stefan Berger28 Sep 2007 08:20 
Coker, George28 Sep 2007 09:03 
Subject:Re: [Xen-devel] Re: [Xense-devel][XSM:ACM][PATCH] nulldereference bug fix
From:Coker, George (gsco@tycho.ncsc.mil)
Date:09/28/2007 09:03:55 AM
List:com.xensource.lists.xen-devel

On Fri, 2007-09-28 at 11:20 -0400, Stefan Berger wrote:

[...]

Ok, but then the null dereference issue still exists within the context of XSM. The options are:

1) Follow acm_free_domain_ssid(d->ssid) with d->ssid = NULL (I've tested this and it maintains the desired policy state:

Confict Sets:

c-set 0: 00 01 00 01

Running Types: 01 01 00 00

Conflict Aggregate Set: 00 00 00 01

but seems less attractive from a coding style perspective)

or

2) Chance acm_free_domain_ssid to pass d instead of ssid and ensure that d->ssid = NULL in acm_free_domain_ssid.

Sounds like this is cleaner and so I opt for this choice.

I've just posted a patch. Would you care to check it out and Ack it to avoid any confusion?

George