16 messages in com.xensource.lists.xen-develRe: [Xen-devel] [PATCH] serialize sus...
FromSent OnAttachments
BVK Chaitanya31 Jul 2008 04:04.patch
Keir Fraser31 Jul 2008 04:17 
BVK Chaitanya31 Jul 2008 04:52 
Keir Fraser31 Jul 2008 05:22 
BVK Chaitanya31 Jul 2008 05:59 
Keir Fraser31 Jul 2008 06:06 
BVK Chaitanya31 Jul 2008 06:33 
Keir Fraser31 Jul 2008 06:46 
BVK Chaitanya31 Jul 2008 07:06 
Neil Turton31 Jul 2008 07:11 
Keir Fraser31 Jul 2008 07:36 
BVK Chaitanya31 Jul 2008 08:23 
Keir Fraser31 Jul 2008 08:24 
BVK Chaitanya31 Jul 2008 22:26 
BVK Chaitanya31 Jul 2008 22:53 
Keir Fraser01 Aug 2008 01:01 
Subject:Re: [Xen-devel] [PATCH] serialize suspend-resume process
From:Keir Fraser (keir@eu.citrix.com)
Date:07/31/2008 05:22:41 AM
List:com.xensource.lists.xen-devel

On 31/7/08 12:57, "BVK Chaitanya" <baya@symantec.com> wrote:

Yes, but there must be a way for dom0 to know that suspend-resume cycle is completed. Currently dom0 only gets suspend completed notification -- as part of shutdown hypercall -- but no resume (xenbus_suspend_cancel) completed notification.

If dom0 issues second suspend request before resume is completed a _new_ kthread is started and will proceed with xen_suspend in parallel. I saw this hitting BUG_ON in netfront_accelerator_add_watch.

That isn't true. xen_suspend() can only be re-entered after it has switched the 'shutting_down' variable to SHUTDOWN_INVALID. At this point resume work is completed (except perhaps for resuming some PV devices via xenbus, which is done asynchronously).

Your BUG_ON() may be fixed by linux-2.6.18-xen.hg, changeset 622.

-- Keir