Re: Note routing - Jostein Martinsen - com.mysql.lists.eventum-users

4 messages in com.mysql.lists.eventum-usersRe: Note routing

From	Sent On	Attachments
Jostein Martinsen	28 Sep 2007 00:11
Elan Ruusamäe	01 Oct 2007 10:12
Jostein Martinsen	01 Oct 2007 12:55
Jostein Martinsen	01 Oct 2007 13:04

Subject:	Re: Note routing
From:	Jostein Martinsen (jost...@redpill.se)
Date:	10/01/2007 01:04:10 PM
List:	com.mysql.lists.eventum-users

Hm Elan was right, I had a malformed e-mail as input when I did note routing tests :(

sorry for the inconvenience.

I don't think so. It work very well now with my changes.

On Mon, 1 Oct 2007 20:13:09 +0300 Elan Ruusamäe <gl...@delfi.ee> wrote:

i think you misunderstood the concept. addresses contain ids of issue's not note id's themselves.

ie: issue-XXX@ would send email to issue XXX note-XXX@ would send note to issue XXX

On Friday 28 September 2007 10:11, Jostein Martinsen wrote:

Ello everybody

Was debugging the note routing in Eventum and got it to work with the following changes. I have edited the diff output in order to make it more generic to everyone, so the line-numbers might be wrong! The patch is made out of Eventum 1.6 code, but the same problem exists in Eventum 2.

Index: /trunk/site/include/class.routing.php =================================================================== --- /trunk/site/include/class.routing.php (revision 1) +++ /trunk/site/include/class.routing.php (revision 3) @@ -474,5 +474,18 @@ foreach ($addresses as $address) { if (preg_match("/$prefix(\d*)@$mail_domain/i", $address, $matches)) { - return $matches[1]; + if($type == "note") + { + return Note::getIssueID( $matches[1] ); + } + else + { + return $matches[1]; + } } }