91 messages in com.xensource.lists.xen-devel[Xen-devel] Re: [PATCH 00 of 36] x86/...
FromSent OnAttachments
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:18 
Jeremy Fitzhardinge24 Jun 2008 21:19 
Jeremy Fitzhardinge24 Jun 2008 21:19 
Jeremy Fitzhardinge24 Jun 2008 21:19 
Jeremy Fitzhardinge24 Jun 2008 21:19 
Jeremy Fitzhardinge24 Jun 2008 21:19 
Jeremy Fitzhardinge24 Jun 2008 21:19 
Jeremy Fitzhardinge24 Jun 2008 21:19 
Jeremy Fitzhardinge24 Jun 2008 21:19 
Jeremy Fitzhardinge24 Jun 2008 21:19 
Jeremy Fitzhardinge24 Jun 2008 21:19 
Arjan van de Ven24 Jun 2008 21:44 
Ingo Molnar25 Jun 2008 01:42 
Ingo Molnar25 Jun 2008 01:46 
Jeremy Fitzhardinge25 Jun 2008 04:46 
Jeremy Fitzhardinge25 Jun 2008 04:48 
Andi Kleen25 Jun 2008 05:39 
Ingo Molnar25 Jun 2008 08:21 
Keir Fraser25 Jun 2008 11:45 
Keir Fraser25 Jun 2008 12:22 
Jeremy Fitzhardinge25 Jun 2008 13:03 
Jeremy Fitzhardinge25 Jun 2008 13:12 
Jeremy Fitzhardinge25 Jun 2008 14:08 
Jeremy Fitzhardinge25 Jun 2008 16:05 
Jeremy Fitzhardinge25 Jun 2008 16:37 
Ingo Molnar26 Jun 2008 03:56 
Ingo Molnar26 Jun 2008 03:57 
Jeremy Fitzhardinge26 Jun 2008 07:28 
Jeremy Fitzhardinge26 Jun 2008 07:33 
Jeremy Fitzhardinge26 Jun 2008 11:25 
Jeremy Fitzhardinge26 Jun 2008 12:02 
Ingo Molnar27 Jun 2008 08:56 
Jeremy Fitzhardinge27 Jun 2008 09:01 
Ingo Molnar27 Jun 2008 09:03 
Ingo Molnar27 Jun 2008 09:06 
Jeremy Fitzhardinge27 Jun 2008 09:25 
Jeremy Fitzhardinge27 Jun 2008 12:03 
Ingo Molnar29 Jun 2008 01:42 
Jeremy Fitzhardinge29 Jun 2008 20:02 
Yinghai Lu29 Jun 2008 21:34 
Jeremy Fitzhardinge29 Jun 2008 22:32 
Ingo Molnar30 Jun 2008 01:21 
Ingo Molnar30 Jun 2008 02:21 
Jeremy Fitzhardinge30 Jun 2008 10:17 
Jeremy Fitzhardinge30 Jun 2008 10:57 
Ingo Molnar30 Jun 2008 11:02 
Ingo Molnar30 Jun 2008 11:11 
Jeremy Fitzhardinge30 Jun 2008 11:36 
Ingo Molnar30 Jun 2008 11:43 
Jeremy Fitzhardinge30 Jun 2008 16:04 
Ingo Molnar01 Jul 2008 01:51 
Ingo Molnar01 Jul 2008 02:21 
Jeremy Fitzhardinge01 Jul 2008 09:10 
Jeremy Fitzhardinge01 Jul 2008 09:13 
Ingo Molnar01 Jul 2008 13:31 
Ingo Molnar03 Jul 2008 02:10 
Jeremy Fitzhardinge03 Jul 2008 08:47 
Yinghai Lu03 Jul 2008 11:20 
Jeremy Fitzhardinge03 Jul 2008 11:25 
Yinghai Lu03 Jul 2008 11:29 
Jeremy Fitzhardinge03 Jul 2008 11:40 
Yinghai Lu03 Jul 2008 11:50 
Yinghai Lu03 Jul 2008 12:19 
Yinghai Lu03 Jul 2008 12:29.patch
Ingo Molnar09 Jul 2008 00:42 
Subject:[Xen-devel] Re: [PATCH 00 of 36] x86/paravirt: groundwork for 64-bit Xen support
From:Jeremy Fitzhardinge (jer@goop.org)
Date:06/26/2008 07:28:28 AM
List:com.xensource.lists.xen-devel

Ingo Molnar wrote:

* Jeremy Fitzhardinge <jer@goop.org> wrote:

It quickly broke the build in testing:

include/asm/pgalloc.h: In function ‘paravirt_pgd_free': include/asm/pgalloc.h:14: error: parameter name omitted arch/x86/kernel/entry_64.S: In file included from arch/x86/kernel/traps_64.c:51:include/asm/pgalloc.h: In function ‘paravirt_pgd_free': include/asm/pgalloc.h:14: error: parameter name omitted

No, looks like my fault. The non-PARAVIRT version of paravirt_pgd_free() is:

static inline void paravirt_pgd_free(struct mm_struct *mm, pgd_t *) {}

but C doesn't like missing parameter names, even if unused.

This should fix it:

that fixed the build but now we've got a boot crash with this config:

time.c: Detected 2010.304 MHz processor. spurious 8259A interrupt: IRQ7. BUG: unable to handle kernel NULL pointer dereference at 0000000000000000 IP: [<0000000000000000>] PGD 0 Thread overran stack, or stack corrupted Oops: 0010 [1] SMP CPU 0

with:

http://redhat.com/~mingo/misc/config-Thu_Jun_26_12_46_46_CEST_2008.bad

Blerg, a contextless NULL rip. Have you done any bisection on it? Could you try again with the same config, but with "CONFIG_PARAVIRT_DEBUG" enabled as well? That will BUG if it turns out to be trying to call a NULL paravirt-op

I'll try to repro here anyway.

i've pushed out the current tip/xen-64bit branch, so that you can see how things look like at the moment, but i cannot put it into tip/master yet.

Yeah, I was expecting things to break somewhere with this lot :/

Could you add this patch? I don't think it will help this case, but it's a bugfix.

J

Subject: x86_64: use SWAPGS_UNSAFE_STACK in ia32entry.S

Use SWAPGS_UNSAFE_STACK in ia32entry.S in the places where the active stack is the usermode stack.

Signed-off-by: Jeremy Fitzhardinge <jere@citrix.com>

--- arch/x86/ia32/ia32entry.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

=================================================================== --- a/arch/x86/ia32/ia32entry.S +++ b/arch/x86/ia32/ia32entry.S @@ -98,7 +98,7 @@ CFI_SIGNAL_FRAME CFI_DEF_CFA rsp,0 CFI_REGISTER rsp,rbp - SWAPGS + SWAPGS_UNSAFE_STACK movq %gs:pda_kernelstack, %rsp addq $(PDA_STACKOFFSET),%rsp /* @@ -210,7 +210,7 @@ CFI_DEF_CFA rsp,PDA_STACKOFFSET CFI_REGISTER rip,rcx /*CFI_REGISTER rflags,r11*/ - SWAPGS + SWAPGS_UNSAFE_STACK movl %esp,%r8d CFI_REGISTER rsp,r8 movq %gs:pda_kernelstack,%rsp

_______________________________________________ Xen-devel mailing list Xen-@lists.xensource.com http://lists.xensource.com/xen-devel