Re: [Xen-devel] [PATCH]local apic initialization - Keir Fraser - com.xensource.lists.xen-devel

4 messages in com.xensource.lists.xen-develRe: [Xen-devel] [PATCH]local apic ini...

From	Sent On	Attachments
Natasha Jarymowycz	23 Mar 2005 13:28	.patch, .patch, .patch
Natasha Jarymowycz	24 Mar 2005 05:57
Ian Pratt	25 Mar 2005 13:23
Keir Fraser	25 Mar 2005 13:45

Subject:	Re: [Xen-devel] [PATCH]local apic initialization
From:	Keir Fraser (Keir...@cl.cam.ac.uk)
Date:	03/25/2005 01:45:59 PM
List:	com.xensource.lists.xen-devel

On 25 Mar 2005, at 21:23, Ian Pratt wrote:

It didn't apply totally cleanly, but I fixed it up, and it booted OK for me.

How much testing have you been able to give the patch?

I'm not sure that some of the #if 0's are actually going to help from a maintenance POV, so it might actually be better to remove any whole functions etc that aren't used.

I'd make it a pre-condition of acceptance: the patch will be much smaller since a lot of the added code fragments are actually if 0'ed out. It makes it hard to work out what moving parts have actually changed.

-- Keir