Keir Fraser wrote:
On 28 Jun 2006, at 19:02, Nakajima, Jun wrote:
Sorry, I actually meant get/put_page_from_l1e(). Does that make the
problem easier? I'd be prepared to add an extra parameter to those
functions if really necessary.
That would be sensible ;-) I think we need to add an extra parameter
to those to specify the context (guest or shadow, for example)
rather than who's calling.
Since it's just get/put_page_from_l1e I think we should just duplicate
the required bits in the shadow code. Could the required parts be
merged into shadow_get/put_page_from_l1e()? For example, non of the
I/O-page mapping stuff is needed at all yet. We could for now BUG_ON
!valid_mfn() and flags in L1_DISALLOW_MASK.
Yes, we can merge the required parts into
shadow_get/put_page_from_l1e().
We still need to change get/put_page_from_l1e to prevent qemu-dm from
changing type_info, but we don't need to add an extra parameter that
way.
Could you split your original patch into the updated changes to shadow
mode, and a separate patch for the actual mapcache logic?
I'll do that.
Jun
10 messages in com.xensource.lists.xen-develRE: [Xen-devel] [PATCH][HVM] Removing...
.patch