10 messages in com.xensource.lists.xen-devel[Xen-devel] Re: [rfc] [patch] grant_e...
FromSent OnAttachments
Hollis Blanchard23 Jun 2006 14:19 
Keir Fraser27 Jun 2006 03:39 
Hollis Blanchard27 Jun 2006 08:06 
Keir Fraser27 Jun 2006 08:23 
Hollis Blanchard27 Jun 2006 09:11 
Keir Fraser27 Jun 2006 09:54 
Jimi Xenidis27 Jun 2006 10:44 
Keir Fraser27 Jun 2006 23:42 
Hollis Blanchard28 Jun 2006 10:07 
Hollis Blanchard29 Jun 2006 14:18 
Subject:[Xen-devel] Re: [rfc] [patch] grant_entry.flags accessors
From:Keir Fraser (Keir@cl.cam.ac.uk)
Date:06/27/2006 08:23:58 AM
List:com.xensource.lists.xen-devel

On 27 Jun 2006, at 16:06, Hollis Blanchard wrote:

In the couple cases so far, we know that even though the field is only one or two bytes, it's actually safe to do a four-byte load/store to it because the containing structure is large enough.

I'm not really comfortable with making that a blanket assumption. I'd really like to know exactly what we're overwriting when performing these hacks^Woperations.

You won't be overwriting anything else since you'll be performing an atomic read-modify-write that does not change any of the bits outside the subword of interest. More precisely, you may overwrite those bits outside the subword, but it's guaranteed to be with the current contents so there'll be no externally visible change and you won't clobber anything. Since you'll do an aligned longword operation you can't end up straddling a page boundary or anything nasty like that.

-- Keir