On Thu, Aug 26, 2010 at 19:19, Justin Edelson <just...@gmail.com> wrote:
I agree with Alex that forwarding doesn't seem right. If one was to use an existing SlingPostOperation to create a composite (which is what this looks like), you would probably want to use a transaction and only commit the transaction at the end of the composite.
Right, I didn't think about the location of the save() call. It
happens at the end of the SlingPostOperation.run(), which would be ok,
since I do my stuff beforehand in case of forwarding.
But for a general re-use of SlingPostOperation it might be necessary
to pass some "autoSave=true/false" parameter to the operation. Or
maybe a SlingPostProcessor is enough.
It isn't directly related, but looking at the dependency between the two jackrabbit bundles and servlets.post (and some of my own code) along with this thread makes me think we do need to expose more of the post servlet innards to other bundles. There's good stuff in there which is of general use. As this means new APIs, let's be thoughtful about it.
In the interim... Alex - can you use Embed-Dependency like jackrabbit-accessmanager does? It's not pretty, but works.
Ahem, yes, I could, but Felix would probably kill me for doing that ;-)