43 messages in org.apache.mina.devRe: svn commit: r659372 - /mina/branc...
FromSent OnAttachments
Emmanuel LecharnyMay 22, 2008 7:40 pm 
이희승 (Trustin Lee)May 22, 2008 7:46 pm 
Emmanuel LecharnyMay 22, 2008 8:02 pm 
이희승 (Trustin Lee)May 22, 2008 8:14 pm 
Emmanuel LecharnyMay 22, 2008 8:21 pm 
Emmanuel LecharnyMay 22, 2008 8:24 pm 
이희승 (Trustin Lee)May 22, 2008 8:30 pm 
Emmanuel LecharnyMay 22, 2008 8:43 pm 
이희승 (Trustin Lee)May 22, 2008 8:48 pm 
Mike HeathMay 22, 2008 9:52 pm 
이희승 (Trustin Lee)May 22, 2008 9:59 pm 
이희승 (Trustin Lee)May 22, 2008 10:20 pm 
Emmanuel LecharnyMay 22, 2008 10:31 pm 
이희승 (Trustin Lee)May 22, 2008 10:35 pm 
Mike HeathMay 22, 2008 10:44 pm 
Rich DoughertyMay 22, 2008 11:24 pm 
Julien VermillardMay 22, 2008 11:37 pm 
이희승 (Trustin Lee)May 22, 2008 11:44 pm 
Julien VermillardMay 23, 2008 12:13 am 
이희승 (Trustin Lee)May 23, 2008 12:39 am 
Michael QiMay 23, 2008 12:46 am 
Stefano BagnaraMay 23, 2008 1:09 am 
Stefano BagnaraMay 23, 2008 1:17 am 
Julien VermillardMay 23, 2008 1:21 am 
Brad HarveyMay 23, 2008 1:45 am 
Mark WebbMay 23, 2008 6:09 am 
Brad HarveyMay 23, 2008 6:31 am 
Niklas TherningMay 23, 2008 6:54 am 
Alex KarasuluMay 23, 2008 7:30 am 
Emmanuel LecharnyMay 23, 2008 7:50 am 
Emmanuel LecharnyMay 23, 2008 8:07 am 
Julien VermillardMay 23, 2008 8:44 am 
Stefano BagnaraMay 23, 2008 10:03 am 
Alex KarasuluMay 23, 2008 10:14 am 
Mark WebbMay 23, 2008 10:16 am 
Stefano BagnaraMay 23, 2008 10:26 am 
Stefano BagnaraMay 23, 2008 10:28 am 
Emmanuel LecharnyMay 23, 2008 10:40 am 
Mark WebbMay 23, 2008 1:43 pm 
Emmanuel LecharnyMay 23, 2008 2:23 pm 
jver...@archean.frMay 24, 2008 11:07 pm 
Frédéric BrégierMay 24, 2008 11:26 pm 
Emmanuel LecharnyMay 25, 2008 4:00 am 
Actions with this message:
Paste this link in email or IM:
Paste this link in email or IM:
Atom feed for this thread
Paste this URL into your reader:
Subject:Re: svn commit: r659372 - /mina/branches/buffer/core/src/main/java/org/apache/mina/queue/DefaultByteBufferQueue.javaActions...
From:Stefano Bagnara (apa@bago.org)
Date:May 23, 2008 1:09:10 am
List:org.apache.mina.dev

Emmanuel Lecharny ha scritto:

이희승 (Trustin Lee) wrote:

On Fri, 23 May 2008 12:21:43 +0900, Emmanuel Lecharny

Sometime, you just have to use vi or emacs. Make it simple for users : add a @see tag. Cost almost nothing, and it helps.

I wouldn't bother with vi or emacs. They pay for what they use. Moreover, it's not 'almost nothing'.

-1.

Please revert the commit.

Thanks.

Emmanuel, are you vetoing the commit because an inherited class (having full javadocs for the superclass) does not have method comments?

Isn't this a bit hard at this point of the discussion?

FWIW (I'm not committer to mina, but only a developer) I agree with Trustin.

If a @see is useful then the javadoc tools should automatically add the see to every implementation method having no javadoc. This is about javadoc tools, not documentation. The documentation is already in the java source keywords "extends" and "implements".

Stefano