69 messages in com.selenic.mercurial-develRe: [PATCH 3 of 4] log: add a marker ...| From | Sent On | Attachments |
|---|---|---|
| Martin Geisler | May 7, 2010 10:33 am | |
| Dirkjan Ochtman | May 7, 2010 10:37 am | |
| Matt Mackall | May 7, 2010 10:59 am | |
| Martin Geisler | May 7, 2010 11:14 am | |
| Matt Mackall | May 7, 2010 11:46 am | |
| Dirkjan Ochtman | May 7, 2010 1:14 pm | |
| Gilles Moris | May 8, 2010 12:10 am | |
| Martin Geisler | May 8, 2010 1:31 am | |
| Martin Geisler | May 8, 2010 1:34 am | |
| Martin Geisler | May 8, 2010 1:48 am | |
| Martin Geisler | May 8, 2010 2:09 am | |
| Gilles Moris | May 8, 2010 3:50 am | |
| Martin Geisler | May 8, 2010 1:10 pm | |
| Gilles Moris | May 9, 2010 9:33 am | |
| Gilles Moris | May 9, 2010 1:49 pm | |
| Gilles Moris | May 9, 2010 1:49 pm | |
| Gilles Moris | May 9, 2010 1:49 pm | |
| Gilles Moris | May 9, 2010 1:49 pm | |
| Gilles Moris | May 9, 2010 1:49 pm | |
| Matt Mackall | May 9, 2010 2:36 pm | |
| Matt Mackall | May 9, 2010 2:43 pm | |
| Matt Mackall | May 9, 2010 2:45 pm | |
| Matt Mackall | May 9, 2010 2:47 pm | |
| Martin Geisler | May 9, 2010 4:11 pm | |
| Dirkjan Ochtman | May 9, 2010 10:50 pm | |
| Gilles Moris | May 9, 2010 11:31 pm | |
| Gilles Moris | May 9, 2010 11:49 pm | |
| Matt Mackall | May 10, 2010 12:04 am | |
| Gilles Moris | May 10, 2010 12:37 am | |
| Gilles Moris | May 10, 2010 12:37 am | |
| Matt Mackall | May 10, 2010 12:38 am | |
| Matt Mackall | May 10, 2010 12:58 am | |
| Sune Foldager | May 11, 2010 2:02 am | |
| Sune Foldager | May 11, 2010 2:08 am | |
| Sune Foldager | May 11, 2010 2:14 am | |
| Sune Foldager | May 11, 2010 2:20 am | |
| Matt Mackall | May 11, 2010 3:53 pm | |
| Matt Mackall | May 11, 2010 3:56 pm | |
| Gilles Moris | May 12, 2010 12:52 am | |
| Gilles Moris | May 12, 2010 1:15 am | |
| Gilles Moris | May 12, 2010 1:15 am | |
| Gilles Moris | May 12, 2010 1:15 am | |
| Gilles Moris | May 12, 2010 1:15 am | |
| Gilles Moris | May 12, 2010 1:15 am | |
| Gilles Moris | May 12, 2010 5:17 am | |
| Augie Fackler | May 12, 2010 7:35 am | |
| Matt Mackall | May 12, 2010 8:33 am | |
| Matt Mackall | May 12, 2010 8:34 am | |
| Matt Mackall | May 12, 2010 8:34 am | |
| Matt Mackall | May 12, 2010 8:55 am | |
| Gilles Moris | May 12, 2010 2:33 pm | |
| Gilles Moris | May 13, 2010 7:31 am | |
| Matt Mackall | May 13, 2010 1:48 pm | |
| Martin Geisler | May 17, 2010 1:09 am | |
| Martin Geisler | May 17, 2010 1:22 am | |
| Rafael Villar Burke (Pachi) | May 17, 2010 2:07 am | |
| Augie Fackler | May 17, 2010 5:57 am | |
| Martin Geisler | May 17, 2010 6:56 am | |
| Augie Fackler | May 17, 2010 7:46 am | |
| Martin Geisler | May 17, 2010 8:13 am | |
| Augie Fackler | May 17, 2010 8:41 am | |
| Gilles Moris | May 19, 2010 8:00 am | |
| Martin Geisler | May 19, 2010 3:53 pm | |
| Martin Geisler | May 19, 2010 3:58 pm | |
| Augie Fackler | May 24, 2010 5:15 am | |
| Peter Arrenbrecht | May 26, 2010 6:23 am | |
| Rafael Fernández López | Jun 3, 2010 5:35 am | |
| Peter Arrenbrecht | Jun 3, 2010 6:14 am | |
| Martin Geisler | Jun 4, 2010 12:18 am |
| Subject: | Re: [PATCH 3 of 4] log: add a marker for closed heads | |
|---|---|---|
| From: | Gilles Moris (gill...@free.fr) | |
| Date: | May 10, 2010 12:37:25 am | |
| List: | com.selenic.mercurial-devel | |
On Sunday 09 May 2010 11:37:27 pm Matt Mackall wrote:
# HG changeset patch # User Gilles Moris <gill...@free.fr> # Date 1273437800 -7200 # Node ID 4f227e0671ba95e075ecdc2d2a6b5f3f0072e5bf # Parent 3615f282d6f08fb99976b86816ff37c019b8187a log: add a marker for closed heads
Hey folks, when you send a patch like this, -please- show us what it looks like right up front, not way down in some tests.
This one is scary. Lots of people parse 'hg log' and a new thingy showing up there where there's never been one before is liable to break things. There are like dozens of GUI tools and IDE plug-ins these days and it's a sure bet that one of them will break, never mind all the home-grown scripts that are doing something with log output.
Yes, of course.
diff -r 3615f282d6f0 -r 4f227e0671ba mercurial/cmdutil.py --- a/mercurial/cmdutil.py Sun May 09 22:42:06 2010 +0200 +++ b/mercurial/cmdutil.py Sun May 09 22:43:20 2010 +0200 @@ -737,8 +737,10 @@ parents = [(p, hexfunc(log.node(p))) for p in self._meaningful_parentrevs(log, rev)]
- self.ui.write(_("changeset: %d:%s\n") % (rev, hexfunc(changenode)), + self.ui.write(_("changeset: %d:%s") % (rev, hexfunc(changenode)), label='log.changeset') + self.ui.write(templatekw.showclosed(ctx=ctx), label='log.closed')
Calling into the templater code in the non-template path is not great.
We must ensure that the hardcoded log style is the same that the templater log style. So even though the coding style here is not great, at least it's efficient to achieve this goal. Do you see a better solution to do both ?
und on branches b -changeset: 12:2da6583810df +changeset: 12:2da6583810df (closed) branch: b
Seems it should be attached to branch: instead, setting aside the output stability issue for a moment.
Actually, it's a head which is closed, not a branch. So I am not sure attaching it to "branch:" is good. So may be an optional line below the changeset line would make it ? There are more optional lines below for branches and tags anyway.
Regards. Gilles.
_______________________________________________ Mercurial-devel mailing list Merc...@selenic.com http://selenic.com/mailman/listinfo/mercurial-devel